[webui] readd a creator function for requests

src/webui/app/controllers/request_controller.rb

@@ -121,7 +121,7 @@ def changerequest
           else
             target = find_cached(Project, tprj)
           end
-          target.add_person(:userid => BsRequest.creator(@req).login, :role => "maintainer")
+          target.add_person(:userid => @req.creator, :role => "maintainer")
           target.save
         end
       end

src/webui/app/models/bs_request.rb

@@ -202,4 +202,10 @@ def reviewer_for_history_item(item)
     end
     return reviewer
   end
+
+  # return the login of the creator - to be obsoleted soon (FIXME2.4)
+  def creator
+    details = ApiDetails.find(:request_show, id: self.id)
+    return details['creator']
+  end
 end

src/webui/app/views/shared/_requests_small.html.erb

@@ -8,7 +8,7 @@
           <td style="border: medium none; padding: 0px;">
             <%= link_to("##{req.value(:id)}", :controller => :request, :action => :show, :id => req.value(:id)) -%>
             by
-            <%= render :partial => 'shared/user_with_realname_and_icon', :locals => {:user => BsRequest.creator(req).login, :short => true}%>
+            <%= render :partial => 'shared/user_with_realname_and_icon', :locals => {:user => req.creator, :short => true}%>
             (<%= fuzzy_time_string(req.state.value :when) %>)
           </td>
         </tr>