Skip to content

Commit

Permalink
Adapt specs to cover report's comments
Browse files Browse the repository at this point in the history
Co-authored-by: Eduardo Navarro <enavarro@suse.com>
  • Loading branch information
saraycp and eduardoj committed Apr 25, 2024
1 parent 99446cc commit 6841241
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/api/spec/factories/comments.rb
Expand Up @@ -16,6 +16,10 @@
commentable { create(:set_bugowner_request) }
end

factory :comment_report do
commentable { create(:report) }
end

trait :bs_request_action do
commentable factory: [:bs_request_with_submit_action]
end
Expand Down
21 changes: 21 additions & 0 deletions src/api/spec/policies/comment_policy_spec.rb
Expand Up @@ -72,6 +72,16 @@
it { is_expected.to permit(user, comment_on_request) }
it { is_expected.not_to permit(other_user, comment_on_request) }
end

context 'with a comment of a Report' do
let(:user_with_moderator_role) { create(:moderator) }
let(:another_user_with_moderator_role) { create(:moderator) }
let(:comment_on_report) { create(:comment_request, user: user_with_moderator_role) }

it { is_expected.to permit(user_with_moderator_role, comment_on_report) }
it { is_expected.not_to permit(another_user_with_moderator_role, comment_on_report) }
it { is_expected.not_to permit(other_user, comment_on_report) }
end
end

permissions :update? do
Expand Down Expand Up @@ -234,5 +244,16 @@
it { is_expected.to permit(author, comment_on_comment_locked_project) }
end
end

context 'for a commentable which is a report' do
let(:user_with_moderator_role) { create(:moderator) }
let(:another_user) { create(:confirmed_user) }
let(:comment_on_report) { build(:comment_request, user: user_with_moderator_role) }

it { is_expected.to permit(user_with_moderator_role, comment_on_report) }
it { is_expected.to permit(admin_user, comment_on_report) }
it { is_expected.to permit(comment_author, comment_on_report) }
it { is_expected.to permit(another_user, comment_on_report) }
end
end
end

0 comments on commit 6841241

Please sign in to comment.