Merge pull request #15097 from hennevogel/refactoring/includeallpacka…

…ges_keyword_argument

Make includeallpackages a boolean keyword argument

src/api/app/controllers/source_controller.rb

@@ -564,7 +564,7 @@ def project_command_undelete
   def project_command_release
     params[:user] = User.session!.login
 
-    @project = Project.get_by_name(params[:project], includeallpackages: 1)
+    @project = Project.get_by_name(params[:project], include_all_packages: true)
     verify_release_targets!(@project)
 
     if @project.is_a?(String) # remote project
@@ -663,7 +663,7 @@ def project_command_copy
     raise CmdExecutionNoPermission, "no permission to execute command 'copy'" unless (@project && User.session!.can_modify?(@project)) ||
                                                                                      (@project.nil? && User.session!.can_create_project?(project_name))
 
-    oprj = Project.get_by_name(params[:oproject], includeallpackages: 1)
+    oprj = Project.get_by_name(params[:oproject], include_all_packages: true)
     if params.key?(:makeolder) || params.key?(:makeoriginolder)
       raise CmdExecutionNoPermission, "no permission to execute command 'copy', requires modification permission in origin project" unless User.session!.can_modify?(oprj)
     end

src/api/app/models/project.rb

@@ -235,15 +235,15 @@ def check_access?(project)
     #   - an instance of Project
     #   - a string for a Project from an interconnect
     #   - UnknownObjectError or ReadAccessError exceptions
-    def get_by_name(name, opts = {})
+    def get_by_name(name, include_all_packages: false)
       dbp = find_by_name(name, skip_check_access: true)
       if dbp.nil?
         dbp, remote_name = find_remote_project(name)
         return dbp.name + ':' + remote_name if dbp
 
         raise Project::Errors::UnknownObjectError, "Project not found: #{name}"
       end
-      if opts[:includeallpackages]
+      if include_all_packages
         Package.joins(:flags).where(project_id: dbp.id).where("flags.flag='sourceaccess'").find_each do |pkg|
           raise ReadAccessError, name unless Package.check_access?(pkg)
         end