Merge pull request #8838 from vpereira/move_errors_from_bs_request_pe…

…rmission_check

Move errors from BsRequestPermissionCheck to BsRequest::Errors

src/api/app/models/bs_request/errors.rb

@@ -16,4 +16,41 @@ class UnderEmbargo < APIError
   class SaveError < APIError
     setup 'request_save_error'
   end
+  class AddReviewNotPermitted < APIError
+    setup 403
+  end
+
+  class NotExistingTarget < APIError
+    setup 404
+  end
+
+  class SourceChanged < APIError
+  end
+
+  class ReleaseTargetNoPermission < APIError
+    setup 403
+  end
+
+  class ProjectLocked < APIError
+    setup 403, 'The target project is locked'
+  end
+
+  class TargetNotMaintenance < APIError
+    setup 404
+  end
+
+  class SourceMissing < APIError
+    setup 'unknown_package', 404
+  end
+
+  class SetPriorityNoPermission < APIError
+    setup 403
+  end
+
+  class ReviewChangeStateNoPermission < APIError
+    setup 403
+  end
+
+  class ReviewNotSpecified < APIError
+  end
 end

src/api/app/models/bs_request_permission_check.rb

@@ -1,41 +1,5 @@
 class BsRequestPermissionCheck
-  class AddReviewNotPermitted < APIError
-    setup 403
-  end
-
-  class NotExistingTarget < APIError
-    setup 404
-  end
-
-  class SourceChanged < APIError
-  end
-
-  class ReleaseTargetNoPermission < APIError
-    setup 403
-  end
-
-  class ProjectLocked < APIError
-    setup 403, 'The target project is locked'
-  end
-
-  class TargetNotMaintenance < APIError
-    setup 404
-  end
-
-  class SourceMissing < APIError
-    setup 'unknown_package', 404
-  end
-
-  class SetPriorityNoPermission < APIError
-    setup 403
-  end
-
-  class ReviewChangeStateNoPermission < APIError
-    setup 403
-  end
-
-  class ReviewNotSpecified < APIError
-  end
+  include BsRequest::Errors
 
   def cmd_addreview_permissions(permissions_granted)
     unless req.state.in?([:review, :new])