Use query objects when possible

openSUSE · Jul 9, 2021 · 722c920 · 722c920
1 parent a83d008
commit 722c920
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/api/app/jobs/project_create_auto_cleanup_requests_job.rb b/src/api/app/jobs/project_create_auto_cleanup_requests_job.rb
@@ -88,10 +88,12 @@ def project_ready_to_autoclean?(project)
     true
   end
 
-  def open_requests_count(project)
+  def open_requests_count(project_name)
+    OpenRequestsWithProjectAsSourceOrTargetFinder.new(relation, project_name).call.count
+  end
+
+  def relation
     BsRequest.in_states([:new, :review, :declined])
              .joins(:bs_request_actions)
-             .where('bs_request_actions.target_project = ? OR bs_request_actions.source_project = ?', project, project)
-             .count
   end
 end