Refactoring: move in the component everything belongs to its logic

src/api/app/components/bs_request_state_badge_component.rb

@@ -10,7 +10,22 @@ def call
     content_tag(
       :span,
       tag.i(class: 'fas fa-code-pull-request me-1').concat(@bs_request.state),
-      class: ['badge', "bg-#{helpers.request_badge_color(@bs_request.state)}", @css_class]
+      class: ['badge', "bg-#{decode_state_color(@bs_request.state)}", @css_class]
     )
   end
+
+  def decode_state_color(state)
+    case state
+    when :review, :new
+      'secondary'
+    when :declined, :revoke
+      'danger'
+    when :superseded
+      'warning'
+    when :accepted
+      'success'
+    else
+      'dark'
+    end
+  end
 end

src/api/app/helpers/webui/notification_helper.rb

@@ -6,21 +6,6 @@ def link_to_show_less_or_more
     link_to("Show #{less_or_more}", my_notifications_path(parameters))
   end
 
-  def request_badge_color(state)
-    case state
-    when :review, :new
-      'secondary'
-    when :declined, :revoke
-      'danger'
-    when :superseded
-      'warning'
-    when :accepted
-      'success'
-    else
-      'dark'
-    end
-  end
-
   private
 
   def mark_as_read_or_unread_button(notification)

src/api/app/views/webui/request/beta_show.html.haml

@@ -47,7 +47,7 @@
         -# superseded
         - if @bs_request.superseded_by.present?
           %li
-            %mark.text-nowrap.text-light{ class: "bg-#{request_badge_color(@bs_request.state)}" } Superseded
+            %mark.text-nowrap.text-light{ class: "bg-#{BsRequestStateBadgeComponent.decode_state_color(@bs_request.state)}" } Superseded
             by
             = link_to "##{@bs_request.superseded_by}", number: @bs_request.superseded_by
         -# superseding statement