[webui] Cleanup setting of issues in read_patchinfo action

openSUSE · Jul 27, 2015 · 7299aa1 · 7299aa1
1 parent fa16da0
commit 7299aa1
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/src/api/app/controllers/webui/patchinfo_controller.rb b/src/api/app/controllers/webui/patchinfo_controller.rb
@@ -75,14 +75,12 @@ def read_patchinfo
           a.text = 'PLEASE CHECK THE FORMAT OF THE ISSUE'
         end
       end
-      issue = []
+
       issueid = a.value(:id)
-      issueurl = IssueTracker.find_by_name(a.value(:tracker)).to_s
-      if issueurl
-        issueurl = issueurl.show_url_for(issueid)
-      else
-        issueurl = ''
-      end
+      issueurl = IssueTracker.find_by_name(a.value(:tracker))
+      issueurl = issueurl.show_url_for(issueid)
+
+      issue = []
       issue << a.value(:tracker)
       issue << issueid
       issue << issueurl
@@ -91,10 +89,9 @@ def read_patchinfo
     end
 
     if params[:issue].nil?
-      params[:issue] = []
-      params[:issue] << params[:issueid]
+      params[:issue] = [params[:issueid]]
     end
-    unless params[:issueid].nil?
+    if params[:issueid]
       params[:issue] << params[:issueid]
       @issues = params[:issue]
     end