Skip to content

Commit

Permalink
[doc] Update rspec readme
Browse files Browse the repository at this point in the history
Remove adding skip to tests as a valid approach to handle untested code. This
was leading developers to the wrong impression that adding skips in our test suite
is a valid approach when migrating tests, or even writing new features.

It's not! Skips should be used in rare exceptions, when we can't fix a broken
test right away.
In any other case we should aim for writing the test!
  • Loading branch information
bgeuken committed Apr 5, 2016
1 parent 4332f59 commit 74a7423
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/api/spec/README.md
Expand Up @@ -70,14 +70,7 @@ file path of the new one to every test covered.

### Untested methods
When you work on the test suite and you notice a method or part of a feature that
is not tested please either add a test for it or at least add a skipped test case
like this

```ruby
describe "some method/feature" do
skip
end
```
is not tested please add a test for it.

## Better Specs
As a set of "rules" to follow in our specs we use [BetterSpecs.org](http://betterspecs.org/).
Expand Down

0 comments on commit 74a7423

Please sign in to comment.