Merge pull request #5191 from bgeuken/factory_plugin/tests

Factory plugin/tests

src/api/app/models/obs_factory/distribution_strategy_factory.rb

@@ -1,6 +1,8 @@
 module ObsFactory
   # this is not a Factory pattern, this is for openSUSE:Factory :/
   class DistributionStrategyFactory
+    include ActiveModel::Model
+
     attr_accessor :project
 
     # String to pass as version to filter the openQA jobs

src/api/app/models/obs_factory/distribution_strategy_sle15.rb

@@ -17,12 +17,8 @@ def test_dvd_prefix
     end
 
     def sp_version(name)
-      if name.start_with? 'SUSE:SLE-15:GA'
-        nil
-      else
-        match = name.match(/SUSE:SLE-15-(.*):GA/)
-        match[1]
-      end
+      /SUSE:SLE-15-(?<service_pack>.*):GA/ =~ name
+      service_pack
     end
 
     # Name of the ISO file by the given staging project tracked on openqa

src/api/spec/models/obs_factory/distribution_strategy_sle15_spec.rb

@@ -0,0 +1,12 @@
+require 'rails_helper'
+
+RSpec.describe ObsFactory::DistributionStrategySLE15 do
+  let(:stategy) { ObsFactory::DistributionStrategySLE15.new(project: create(:project)) }
+
+  describe '#sp_version' do
+    it 'returns the correct service pack version' do
+      expect(stategy.sp_version('SUSE:SLE-15:GA')).to be_nil
+      expect(stategy.sp_version('SUSE:SLE-15-SP4:GA')).to eq('SP4')
+    end
+  end
+end