Update Rubocop's TODOs files

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2020-07-27 13:50:10 UTC using RuboCop version 0.88.0.
+# on 2020-08-13 15:42:38 UTC using RuboCop version 0.89.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -22,7 +22,7 @@ Lint/UselessAssignment:
   Exclude:
     - 'dist/obs_mirror_project'
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/AbcSize:
   Exclude:
@@ -53,12 +53,6 @@ Metrics/ParameterLists:
   Exclude:
     - 'dist/clouduploader.rb'
 
-# Offense count: 1
-# Configuration parameters: IgnoredMethods, Max.
-Metrics/PerceivedComplexity:
-  Exclude:
-    - 'dist/obs_mirror_project'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
@@ -88,11 +82,22 @@ Style/FrozenStringLiteralComment:
     - 'docs/dev/controller_template_example.rb'
     - 'docs/dev/model_template_example.rb'
 
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/GlobalStdStream:
+  Exclude:
+    - 'dist/clouduploader.rb'
+
 # Offense count: 1
 Style/MixinUsage:
   Exclude:
     - 'dist/obs_mirror_project'
 
+# Offense count: 1
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'Rakefile'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/PerlBackrefs:

src/api/.rubocop_todo.yml

@@ -1,11 +1,17 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2020-07-30 10:46:45 UTC using RuboCop version 0.88.0.
+# on 2020-08-13 15:45:18 UTC using RuboCop version 0.89.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 2
+Lint/BinaryOperatorWithIdenticalOperands:
+  Exclude:
+    - 'app/models/bs_request.rb'
+    - 'spec/models/bs_request_action/differ/for_source_spec.rb'
+
 # Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
@@ -20,6 +26,14 @@ Lint/MissingCopEnableDirective:
     - 'test/functional/maintenance_test.rb'
     - 'test/functional/request_controller_test.rb'
 
+# Offense count: 4
+Lint/MissingSuper:
+  Exclude:
+    - 'app/lib/backend/remember_location.rb'
+    - 'app/lib/suse/permission.rb'
+    - 'app/presenters/repositories/state_presenter.rb'
+    - 'app/queries/open_requests_with_project_as_source_or_target_finder.rb'
+
 # Offense count: 4
 Lint/NonLocalExitFromIterator:
   Exclude:
@@ -56,6 +70,11 @@ Lint/SuppressedException:
     - 'lib/obsapi/markdown_renderer.rb'
     - 'spec/models/project_spec.rb'
 
+# Offense count: 1
+Lint/UnreachableLoop:
+  Exclude:
+    - 'app/lib/suse/validator.rb'
+
 # Offense count: 34
 Lint/UriEscapeUnescape:
   Exclude:
@@ -74,10 +93,10 @@ Lint/UriEscapeUnescape:
     - 'spec/models/package_spec.rb'
     - 'test/functional/request_controller_test.rb'
 
-# Offense count: 880
+# Offense count: 807
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 195
+  Max: 208
 
 # Offense count: 19
 # Configuration parameters: CountBlocks, Max.
@@ -303,7 +322,7 @@ Metrics/ParameterLists:
     - 'test/functional/source_controller_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 175
+# Offense count: 168
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/PerceivedComplexity:
   Exclude:
@@ -316,9 +335,8 @@ Metrics/PerceivedComplexity:
     - 'app/controllers/request_controller.rb'
     - 'app/controllers/search_controller.rb'
     - 'app/controllers/source_controller.rb'
-    - 'app/controllers/source_project_controller.rb'
     - 'app/controllers/source_project_meta_controller.rb'
-    - 'app/controllers/statistics_controller.rb'
+    - 'app/controllers/webui/monitor_controller.rb'
     - 'app/controllers/webui/package_controller.rb'
     - 'app/controllers/webui/packages/branches_controller.rb'
     - 'app/controllers/webui/packages/files_controller.rb'
@@ -331,19 +349,21 @@ Metrics/PerceivedComplexity:
     - 'app/controllers/webui/webui_controller.rb'
     - 'app/helpers/flag_helper.rb'
     - 'app/helpers/maintenance_helper.rb'
+    - 'app/helpers/model_helper.rb'
     - 'app/helpers/validation_helper.rb'
     - 'app/helpers/webui/buildresult_helper.rb'
     - 'app/helpers/webui/package_helper.rb'
     - 'app/helpers/webui/projects/status_helper.rb'
     - 'app/helpers/webui/user_helper.rb'
     - 'app/helpers/webui/webui_helper.rb'
+    - 'app/jobs/consistency_check_job.rb'
     - 'app/jobs/project_create_auto_cleanup_requests.rb'
     - 'app/lib/backend/connection.rb'
-    - 'app/lib/backend/connection_helper.rb'
     - 'app/lib/backend/test.rb'
     - 'app/lib/suse/validator.rb'
     - 'app/mailers/event_mailer.rb'
-    - 'app/mixins/parse_package_diff.rb'
+    - 'app/mixins/has_relationships.rb'
+    - 'app/models/attrib.rb'
     - 'app/models/attrib_type.rb'
     - 'app/models/binary_release.rb'
     - 'app/models/branch_package.rb'
@@ -352,29 +372,27 @@ Metrics/PerceivedComplexity:
     - 'app/models/bs_request/find_for/query.rb'
     - 'app/models/bs_request_action.rb'
     - 'app/models/bs_request_action/differ/query_builder.rb'
-    - 'app/models/bs_request_action/differ/query_builder_for_superseded.rb'
     - 'app/models/bs_request_action_maintenance_incident.rb'
     - 'app/models/bs_request_action_submit.rb'
     - 'app/models/bs_request_permission_check.rb'
     - 'app/models/channel.rb'
     - 'app/models/event/request.rb'
     - 'app/models/event_subscription/find_for_event.rb'
-    - 'app/models/flag/specified_flags.rb'
     - 'app/models/group.rb'
     - 'app/models/issue_tracker.rb'
-    - 'app/models/linked_project.rb'
+    - 'app/models/kiwi/image/xml_parser.rb'
     - 'app/models/owner_search/assignee.rb'
     - 'app/models/package.rb'
     - 'app/models/package_build_status.rb'
     - 'app/models/patchinfo.rb'
     - 'app/models/product.rb'
     - 'app/models/project.rb'
     - 'app/models/project/update_from_xml_command.rb'
+    - 'app/models/project_status/calculator.rb'
     - 'app/models/relationship.rb'
     - 'app/models/repository.rb'
     - 'app/models/service.rb'
     - 'app/models/unregistered_user.rb'
-    - 'app/models/user.rb'
     - 'app/models/user_ldap_strategy.rb'
     - 'app/policies/attrib_policy.rb'
     - 'config/initializers/wrap_parameters.rb'
@@ -624,7 +642,7 @@ RSpec/EmptyLineAfterFinalLet:
     - 'spec/support/shared_examples/features/boostrap_flag_tables.rb'
     - 'spec/support/shared_examples/features/flags_tables.rb'
 
-# Offense count: 317
+# Offense count: 316
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Exclude:
@@ -742,7 +760,7 @@ RSpec/IteratedExpectation:
   Exclude:
     - 'spec/models/user_spec.rb'
 
-# Offense count: 279
+# Offense count: 280
 # Cop supports --auto-correct.
 RSpec/LeadingSubject:
   Enabled: false
@@ -1266,7 +1284,7 @@ Rails/UniqueValidationWithoutIndex:
     - 'app/models/role.rb'
     - 'app/models/status_message_acknowledgement.rb'
 
-# Offense count: 113
+# Offense count: 114
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -1290,7 +1308,7 @@ Style/CommentedKeyword:
     - 'test/unit/user_ldap_strategy_test.rb'
     - 'test/unit/user_test.rb'
 
-# Offense count: 76
+# Offense count: 75
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
@@ -1306,7 +1324,6 @@ Style/ConditionalAssignment:
     - 'app/controllers/webui/attribute_controller.rb'
     - 'app/controllers/webui/project_controller.rb'
     - 'app/controllers/webui/projects/pulse_controller.rb'
-    - 'app/controllers/webui/webui_controller.rb'
     - 'app/helpers/maintenance_helper.rb'
     - 'app/helpers/webui/request_helper.rb'
     - 'app/helpers/webui/user_helper.rb'
@@ -1347,11 +1364,18 @@ Style/ConditionalAssignment:
     - 'spec/support/database_cleaner.rb'
     - 'test/functional/source_controller_test.rb'
 
-# Offense count: 841
+# Offense count: 843
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1429
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'app/lib/backend/connection.rb'
+    - 'app/models/project.rb'
+
+# Offense count: 1432
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1364,7 +1388,7 @@ Style/IdenticalConditionalBranches:
     - 'app/controllers/build_controller.rb'
     - 'app/controllers/webui/search_controller.rb'
 
-# Offense count: 276
+# Offense count: 274
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
@@ -1460,11 +1484,6 @@ Style/IfUnlessModifier:
     - 'test/test_helper.rb'
     - 'test/unit/schema_test.rb'
 
-# Offense count: 1
-Lint/MissingSuper:
-  Exclude:
-    - 'app/lib/suse/permission.rb'
-
 # Offense count: 2
 Style/MissingRespondToMissing:
   Exclude:
@@ -1526,6 +1545,22 @@ Style/NumericPredicate:
     - 'script/delayed_job_stats.rb'
     - 'test/unit/package_test.rb'
 
+# Offense count: 23
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/controllers/public_controller.rb'
+    - 'app/helpers/webui/buildresult_helper.rb'
+    - 'app/helpers/webui/staging/workflow_helper.rb'
+    - 'app/helpers/webui/webui_helper.rb'
+    - 'app/jobs/consistency_check_job.rb'
+    - 'app/models/attrib_type.rb'
+    - 'app/models/maintenance_incident.rb'
+    - 'app/models/package.rb'
+    - 'app/models/project.rb'
+    - 'app/models/user.rb'
+    - 'app/policies/package_policy.rb'
+    - 'lib/xpath_engine.rb'
+
 # Offense count: 52
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
@@ -1645,7 +1680,18 @@ Style/RescueStandardError:
     - 'lib/tasks/dev.rake'
     - 'lib/tasks/extract.rake'
 
-# Offense count: 338
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SingleArgumentDig:
+  Exclude:
+    - 'app/helpers/webui/maintenance_incident_helper.rb'
+
+# Offense count: 307
+# Cop supports --auto-correct.
+Style/StringConcatenation:
+  Enabled: false
+
+# Offense count: 339
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -1659,7 +1705,7 @@ Style/SymbolArray:
 Style/WordArray:
   Enabled: false
 
-# Offense count: 1831
+# Offense count: 1836
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https