Skip to content

Commit

Permalink
Remove unused methods in Workflow::Step
Browse files Browse the repository at this point in the history
Following the changes from #12439, we can also remove this code.
  • Loading branch information
Dany Marcoux committed Apr 25, 2022
1 parent 97ee301 commit 7d66b77
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions src/api/app/models/workflow/step.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,8 @@ def source_project_name
step_instructions[:source_project]
end

def target_package_names
[target_package_name(short_commit_sha: true)] + multibuild_flavors
end

private

def multibuild_flavors
target_package.multibuild_flavors.collect { |flavor| "#{target_package_name}:#{flavor}" }
end

def target_project_base_name
raise AbstractMethodCalled
end
Expand Down Expand Up @@ -143,30 +135,6 @@ def branch_request_content_gitlab
object_attributes: { source: { default_branch: scm_webhook.payload[:commit_sha] } } }.to_json
end

# TODO: Move to a query object.
def workflow_repositories(target_project_name, filters)
repositories = Project.get_by_name(target_project_name).repositories
return repositories unless filters.key?(:repositories)

return repositories.where(name: filters[:repositories][:only]) if filters[:repositories][:only]

return repositories.where.not(name: filters[:repositories][:ignore]) if filters[:repositories][:ignore]

repositories
end

# TODO: Move to a query object.
def workflow_architectures(repository, filters)
architectures = repository.architectures
return architectures unless filters.key?(:architectures)

return architectures.where(name: filters[:architectures][:only]) if filters[:architectures][:only]

return architectures.where.not(name: filters[:architectures][:ignore]) if filters[:architectures][:ignore]

architectures
end

# Only used in LinkPackageStep and BranchPackageStep.
def validate_source_project_and_package_name
errors.add(:base, "invalid source project '#{source_project_name}'") if step_instructions[:source_project] && !Project.valid_name?(source_project_name)
Expand Down

0 comments on commit 7d66b77

Please sign in to comment.