[backend] be more verbose about project/repo error states

Makes debugging interconnect issues a bit easier.
openSUSE · Jun 4, 2018 · 7edc585 · 7edc585
1 parent ac9c3eb
commit 7edc585
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/src/backend/BSSched/Remote.pm b/src/backend/BSSched/Remote.pm
@@ -319,8 +319,7 @@ sub remotemap2remoteprojs {
     undef $oproj if $oproj && ($oproj->{'remoteurl'} ne $proj->{'remoteurl'} || $oproj->{'remoteproject'} ne $proj->{'remoteproject'});
     my $c = $proj->{'config'};
     $c = $oproj->{'config'} if !defined($c) && $oproj;
-    my $error = $proj->{'error'};
-    delete $proj->{'error'};
+    my $error = delete $proj->{'error'};
     $proj = $oproj if $proj->{'proto'} && $oproj && !$oproj->{'proto'};
     delete $proj->{'config'};
     $proj->{'config'} = $c if defined $c;
@@ -353,8 +352,11 @@ sub addrepo_remote {
   my ($ctx, $pool, $prp, $arch, $remoteproj) = @_;
 
   my ($projid, $repoid) = split('/', $prp, 2);
-  return undef if !$remoteproj || $remoteproj->{'error'};
-
+  return undef unless $remoteproj;
+  if ($remoteproj->{'error'}) {
+    print "    remote project $prp/$arch: $remoteproj->{'error'}\n";
+    return undef;
+  }
   my $gctx = $ctx->{'gctx'};
   print "    fetching remote repository state for $prp\n";
   my $param = {
@@ -493,7 +495,10 @@ sub read_gbininfo_remote {
   my ($ctx, $prpa, $remoteproj, $packstatus) = @_;
 
   return undef unless $remoteproj;
-  return undef if $remoteproj->{'error'};
+  if ($remoteproj->{'error'}) {
+    print "    remote project $prpa: $remoteproj->{'error'}\n";
+    return undef;
+  }
 
   my $gctx = $ctx->{'gctx'};
   my $remotegbininfos = $gctx->{'remotegbininfos'};
@@ -504,6 +509,7 @@ sub read_gbininfo_remote {
 
   # first check error case
   if ($remotegbininfos->{$prpa} && $remotegbininfos->{$prpa}->{'error'} && ($remotegbininfos->{$prpa}->{'lastfetch'} || 0) > $now - 3600) {
+    print "    remote project binary state for $prpa: $remotegbininfos->{$prpa}->{'error'}\n";
     return undef;
   }