Skip to content

Commit

Permalink
Merge pull request #5229 from bgeuken/fix_rubocop_offenses
Browse files Browse the repository at this point in the history
[frontend] Fix rubocop offense: Naming/PredicateName
  • Loading branch information
ChrisBr committed Jun 27, 2018
2 parents 2641fdf + 2956de5 commit 891fc35
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/api/app/models/obs_factory/staging_project.rb
Expand Up @@ -253,7 +253,7 @@ def build_state
:acceptable
end

def is_testing?(openqa_jobs)
def testing?(openqa_jobs)
# empty == the ISOs may still be syncing
openqa_jobs.empty? || openqa_jobs.any? { |job| job.result == 'none' }
end
Expand All @@ -266,7 +266,7 @@ def all_passed?
def openqa_state
# no openqa result for adi staging project
return :acceptable if adi_staging?
return :testing if is_testing?(openqa_jobs)
return :testing if testing?(openqa_jobs)

return :acceptable if all_passed?(openqa_jobs)
# something failed on openqa side, needs manual check
Expand Down

0 comments on commit 891fc35

Please sign in to comment.