Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The check's required function actually checks the checkable of the status_report, which is rather expensive SELECT `status_reports`.* FROM `status_reports` WHERE `status_reports`.`id` = 32 LIMIT 1 [["id", 32], ["LIMIT", 1]] SELECT `repositories`.* FROM `repositories` WHERE `repositories`.`id` = 342446 LIMIT 1 [["id", 342446], ["LIMIT", 1]] And this is done for every check in the report. While we already know the checkable (the repository), so just pass it to the partial.
- Loading branch information
Showing
4 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
render(partial: 'check', locals: { builder: xml, object: @check }) | ||
render(partial: 'check', locals: { builder: xml, object: @check, checkable: @checkable }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters