[ci] Regenerate rubocop todo file

After depfu updating 0.56.0 → 0.57.1.

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-05-22 10:06:28 +0000 using RuboCop version 0.56.0.
+# on 2018-06-07 11:09:38 +0000 using RuboCop version 0.57.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -20,6 +20,16 @@ FactoryBot/DynamicAttributeDefinedStatically:
     - 'src/api/spec/factories/issue.rb'
     - 'src/api/spec/factories/issue_tracker.rb'
 
+# Offense count: 6
+# Cop supports --auto-correct.
+Layout/ClosingHeredocIndentation:
+  Exclude:
+    - 'src/api/db/seeds.rb'
+    - 'src/api/spec/helpers/webui/flash_helper_spec.rb'
+    - 'src/api/spec/models/kiwi/image/xml_builder_spec.rb'
+    - 'src/api/spec/models/kiwi/preference_spec.rb'
+    - 'src/api/spec/models/project_spec.rb'
+
 # Offense count: 17
 # Cop supports --auto-correct.
 Layout/ClosingParenthesisIndentation:
@@ -76,6 +86,11 @@ Layout/IndentationWidth:
     - 'dist/openQA_mail_notification.rb'
     - 'dist/t/spec/spec_helper.rb'
 
+# Offense count: 19
+# Cop supports --auto-correct.
+Layout/LeadingBlankLines:
+  Enabled: false
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Layout/SpaceAfterMethodName:
@@ -182,14 +197,14 @@ Lint/UselessAssignment:
   Exclude:
     - 'dist/obs_mirror_project'
 
-# Offense count: 904
+# Offense count: 905
 Metrics/AbcSize:
   Max: 239
 
-# Offense count: 483
+# Offense count: 485
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 502
+  Max: 493
 
 # Offense count: 24
 # Configuration parameters: CountBlocks.
@@ -199,9 +214,9 @@ Metrics/BlockNesting:
 # Offense count: 90
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 1146
+  Max: 1109
 
-# Offense count: 244
+# Offense count: 245
 Metrics/CyclomaticComplexity:
   Max: 55
 
@@ -220,7 +235,7 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 9
 
-# Offense count: 209
+# Offense count: 210
 Metrics/PerceivedComplexity:
   Max: 55
 
@@ -339,7 +354,7 @@ RSpec/BeforeAfterAll:
     - 'dist/t/spec/features/0040_package_spec.rb'
     - 'src/api/spec/models/relationship_spec.rb'
 
-# Offense count: 475
+# Offense count: 476
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -358,7 +373,7 @@ RSpec/DescribeClass:
     - 'src/api/spec/routing/webui/projects/ssl_certificate_spec.rb'
     - 'src/api/spec/routing/webui_matcher_spec.rb'
 
-# Offense count: 175
+# Offense count: 176
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
@@ -454,10 +469,25 @@ RSpec/ImplicitExpect:
     - 'src/api/spec/models/repository_spec.rb'
     - 'src/api/spec/models/review_spec.rb'
 
-# Offense count: 93
+# Offense count: 83
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
-  Enabled: false
+  Exclude:
+    - 'src/api/spec/controllers/public_controller_spec.rb'
+    - 'src/api/spec/controllers/webui/monitor_controller_spec.rb'
+    - 'src/api/spec/controllers/webui/patchinfo_controller_spec.rb'
+    - 'src/api/spec/controllers/webui/project_controller_spec.rb'
+    - 'src/api/spec/controllers/webui/request_controller_spec.rb'
+    - 'src/api/spec/controllers/webui/users/rss_token_controller_spec.rb'
+    - 'src/api/spec/helpers/webui/patchinfo_helper_spec.rb'
+    - 'src/api/spec/helpers/webui/webui_helper_spec.rb'
+    - 'src/api/spec/models/backend/file_spec.rb'
+    - 'src/api/spec/models/bs_request_spec.rb'
+    - 'src/api/spec/models/group_spec.rb'
+    - 'src/api/spec/models/image_template_spec.rb'
+    - 'src/api/spec/models/project/update_from_xml_command_spec.rb'
+    - 'src/api/spec/models/relationship_spec.rb'
+    - 'src/api/spec/models/review_spec.rb'
 
 # Offense count: 63
 # Configuration parameters: EnforcedStyle.
@@ -481,7 +511,7 @@ RSpec/IteratedExpectation:
     - 'src/api/spec/models/user_spec.rb'
     - 'src/api/spec/script/db_checker.rb'
 
-# Offense count: 87
+# Offense count: 88
 RSpec/LeadingSubject:
   Enabled: false
 
@@ -504,7 +534,7 @@ RSpec/MessageSpies:
 RSpec/MultipleExpectations:
   Max: 15
 
-# Offense count: 521
+# Offense count: 522
 RSpec/NamedSubject:
   Enabled: false
 
@@ -592,12 +622,15 @@ RSpec/VerifiedDoubles:
 Rails/ActiveRecordAliases:
   Enabled: false
 
-# Offense count: 22
+# Offense count: 26
 # Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: **/test/**/*
 Rails/AssertNot:
   Exclude:
+    - 'src/api/test/functional/request_controller_test.rb'
+    - 'src/api/test/functional/search_controller_test.rb'
+    - 'src/api/test/test_helper.rb'
     - 'src/api/test/unit/bs_request_test.rb'
     - 'src/api/test/unit/package_test.rb'
     - 'src/api/test/unit/project_test.rb'
@@ -621,6 +654,8 @@ Rails/CreateTableWithTimestamps:
     - 'src/api/db/migrate/20171030143054_create_kiwi_preference_types.rb'
 
 # Offense count: 85
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
 Rails/FilePath:
   Enabled: false
 
@@ -638,19 +673,7 @@ Rails/HasManyOrHasOneDependent:
     - 'src/api/app/models/static_permission.rb'
     - 'src/api/app/models/user.rb'
 
-# Offense count: 15
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: spec/**/*, test/**/*
-Rails/HttpPositionalArguments:
-  Exclude:
-    - 'src/api/spec/requests/kerberos_login_spec.rb'
-    - 'src/api/test/functional/person_controller_test.rb'
-    - 'src/api/test/functional/read_permission_test.rb'
-    - 'src/api/test/functional/source_controller_test.rb'
-    - 'src/api/test/functional/source_services_test.rb'
-
-# Offense count: 64
+# Offense count: 59
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
@@ -721,7 +744,28 @@ Rails/SkipsModelValidations:
 Rails/TimeZone:
   Enabled: false
 
-# Offense count: 69
+# Offense count: 27
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'src/api/app/controllers/application_controller.rb'
+    - 'src/api/app/controllers/person_controller.rb'
+    - 'src/api/app/controllers/source_controller.rb'
+    - 'src/api/app/controllers/webui/package_controller.rb'
+    - 'src/api/app/models/flag.rb'
+    - 'src/api/app/models/group.rb'
+    - 'src/api/app/models/package_meta_file.rb'
+    - 'src/api/app/models/package_service_error_file.rb'
+    - 'src/api/app/models/project.rb'
+    - 'src/api/app/models/project_config_file.rb'
+    - 'src/api/app/models/project_meta_file.rb'
+    - 'src/api/lib/activexml/node.rb'
+    - 'src/api/test/functional/product_test.rb'
+    - 'src/api/test/functional/read_permission_test.rb'
+    - 'src/api/test/functional/source_controller_test.rb'
+
+# Offense count: 70
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -762,7 +806,7 @@ Style/CommentedKeyword:
     - 'src/api/test/unit/user_ldap_strategy_test.rb'
     - 'src/api/test/unit/user_test.rb'
 
-# Offense count: 92
+# Offense count: 90
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
@@ -811,7 +855,7 @@ Style/FormatStringToken:
     - 'src/api/app/helpers/webui/project_helper.rb'
     - 'src/api/lib/backend/connection_helper.rb'
 
-# Offense count: 999
+# Offense count: 1004
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: when_needed, always, never
@@ -824,7 +868,7 @@ Style/IdenticalConditionalBranches:
     - 'src/api/app/controllers/build_controller.rb'
     - 'src/api/app/controllers/webui/search_controller.rb'
 
-# Offense count: 236
+# Offense count: 235
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -955,7 +999,7 @@ Style/RegexpLiteral:
 Style/RescueStandardError:
   Enabled: false
 
-# Offense count: 71
+# Offense count: 72
 # Cop supports --auto-correct.
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
 # Whitelist: present?, blank?, presence, try, try!
@@ -1001,6 +1045,13 @@ Style/TrivialAccessors:
     - 'src/api/lib/activexml/node.rb'
     - 'src/api/test/test_helper.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/UnneededCondition:
+  Exclude:
+    - 'src/api/app/models/binary_release.rb'
+    - 'src/api/script/import_database.rb'
+
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/UnneededInterpolation: