Merge pull request #10013 from vpereira/refactor_user_relevant_packag…

…es_for_status

Refactor method User#user_relevant_packages_for_status

src/api/app/models/user.rb

@@ -775,16 +775,7 @@ def involved_patchinfos
   end
 
   def user_relevant_packages_for_status
-    role_id = Role.hashed['maintainer'].id
-    # First fetch the project ids
-    projects_ids = involved_projects.select(:id)
-    packages = Package.joins("LEFT OUTER JOIN relationships ON (relationships.package_id = packages.id AND relationships.role_id = #{role_id})")
-    # No maintainers
-    packages = packages.where([
-                                '(relationships.user_id = ?) OR '\
-                                '(relationships.user_id is null AND packages.project_id in (?) )', id, projects_ids
-                              ])
-    packages.pluck(:id)
+    MaintainedPackagesByUserFinder.new(self).call.pluck(:id)
   end
 
   def state

src/api/app/queries/maintained_packages_by_user_finder.rb

@@ -0,0 +1,30 @@
+class MaintainedPackagesByUserFinder
+  def initialize(user)
+    @user = user
+  end
+
+  def call
+    packages_maintained_by_the_user
+  end
+
+  # private
+
+  def maintainer_role_id
+    Role.hashed['maintainer'].id
+  end
+
+  def involved_projects_ids
+    @user.involved_projects.select(:id)
+  end
+
+  def packages_by_role
+    Package.left_outer_joins(:relationships).where('relationships.role_id = ?', maintainer_role_id)
+  end
+
+  def packages_maintained_by_the_user
+    packages_by_role.where([
+                             '(relationships.user_id = ?) OR '\
+                             '(relationships.user_id is null AND packages.project_id in (?) )', @user.id, involved_projects_ids
+                           ])
+  end
+end