Skip to content

Commit

Permalink
[api] fix bug owner assignement of an issue
Browse files Browse the repository at this point in the history
  • Loading branch information
adrianschroeter committed Jan 9, 2012
1 parent ed66bbb commit a19cedb
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
5 changes: 4 additions & 1 deletion src/api/app/controllers/issues_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ class IssuesController < ApplicationController
before_filter :require_admin, :only => [:create, :update, :destroy]

def show
valid_http_methods :get
required_parameters :id, :issue_tracker_id

# NOTE: issue_tracker_id is here actually the name
issue = Issue.get_by_name_and_tracker( params[:id], params[:issue_tracker_id] )
issue = Issue.get_by_name_and_tracker( params[:id], params[:issue_tracker_id], params[:force_update] )
render :text => issue.render_axml, :content_type => 'text/xml'
end
end
11 changes: 6 additions & 5 deletions src/api/app/models/issue.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,13 @@ def render_body(node)
issue.state(self.state) if self.state
issue.description(self.description) if self.description

if self.owner
if self.owner_id
# self.owner must not by used, since it is reserved by rails
o = User.find_by_id self.owner_id
issue.owner do |owner|
owner.login(self.owner.login)
owner.email(self.owner.email)
owner.realname(self.owner.realname)
owner.login(o.login)
owner.email(o.email)
owner.realname(o.realname)
end
end
end
Expand All @@ -69,5 +71,4 @@ def render_axml
builder.to_xml
end


end
1 change: 1 addition & 0 deletions src/api/app/models/issue_tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def fetch_issues(issues=nil)
if issue
issue.state = r["status"]
u = User.find_by_email(r["assigned_to"].to_s)
logger.info "Bug user #{r["assigned_to"].to_s} is not found in OBS user database" unless u
issue.owner_id = u.id if u
issue.description = r["summary"] # FIXME2.3 check for internal only bugs here
issue.save
Expand Down

0 comments on commit a19cedb

Please sign in to comment.