Skip to content

Commit

Permalink
[api] fix crash in maintenance request corner case
Browse files Browse the repository at this point in the history
eg. when revoke a maintenance request, which got an incident set,
but the incident got dropped afterwards.
  • Loading branch information
adrianschroeter committed Jan 18, 2017
1 parent 3993a18 commit a324b0c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/app/models/bs_request_permission_check.rb
Expand Up @@ -193,7 +193,7 @@ def set_permissions_for_action(action, new_state = nil)
if action.action_type == :maintenance_incident
# this action type is always branching using extended names
target_package_name = Package.extended_name(action.source_project, action.source_package)
@target_package = @target_project.packages.find_by_name(target_package_name)
@target_package = @target_project.packages.find_by_name(target_package_name) if @target_project
end

# general source write permission check (for revoke)
Expand Down

0 comments on commit a324b0c

Please sign in to comment.