Merge pull request #12304 from danidoni/replace-uri-encode-with-cgi-u…

…nescape

URI.encode is removed, use Addressable::URI.encode

src/api/app/models/package_file.rb

@@ -6,6 +6,6 @@ class PackageFile < Backend::File
 
   # calculates the real url on the backend to search the file
   def full_path(query = {})
-    URI.encode("/source/#{project_name}/#{package_name}/#{name}") + "?#{query.to_query}"
+    Addressable::URI.encode("/source/#{project_name}/#{package_name}/#{name}") + "?#{query.to_query}"
   end
 end

src/api/app/models/project_config_file.rb

@@ -6,7 +6,7 @@ def initialize(attributes = {})
 
   # calculates the real url on the backend to search the file
   def full_path(query = {})
-    URI.encode("/source/#{project_name}/#{name}") + "?#{query.to_query}"
+    Addressable::URI.encode("/source/#{project_name}/#{name}") + "?#{query.to_query}"
   end
 
   # You dont want to change name of _config

src/api/app/models/project_file.rb

@@ -11,6 +11,6 @@ class ProjectFile < Backend::File
 
   # calculates the real url on the backend to search the file
   def full_path(query = {})
-    URI.encode("/source/#{project_name}/_project/#{name}") + "?#{query.to_query}"
+    Addressable::URI.encode("/source/#{project_name}/_project/#{name}") + "?#{query.to_query}"
   end
 end

src/api/app/models/project_meta_file.rb

@@ -6,7 +6,7 @@ def initialize(attributes = {})
 
   # calculates the real url on the backend to search the file
   def full_path(query = {})
-    URI.encode("/source/#{project_name}/#{name}") + "?#{query.to_query}"
+    Addressable::URI.encode("/source/#{project_name}/#{name}") + "?#{query.to_query}"
   end
 
   # You dont want to change name of _meta

src/api/spec/models/backend/file_spec.rb

@@ -20,7 +20,7 @@
       attr_accessor :somefile
 
       def full_path(_query)
-        URI.encode(somefile)
+        Addressable::URI.encode(somefile)
       end
     end
   end

src/api/test/functional/request_controller_test.rb

@@ -1333,7 +1333,7 @@ def test_search_and_involved_requests
     assert_xml_tag(tag: 'request', attributes: { id: id })
 
     # via POST
-    post '/search/request', params: URI.encode("match=(state/@name='new' or state/@name='review') and (action/target/@project='kde4' and action/target/@package='wpa_supplicant')")
+    post '/search/request', params: Addressable::URI.encode("match=(state/@name='new' or state/@name='review') and (action/target/@project='kde4' and action/target/@package='wpa_supplicant')")
     assert_response :success
     assert_xml_tag(tag: 'request', attributes: { id: id })