Merge pull request #5190 from Ana06/succeed

Refactor how we render superseded requests list
openSUSE · Jun 22, 2018 · aa0c1fc · aa0c1fc
2 parents d0450c5 + 4a5709f
commit aa0c1fc
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/api/app/views/webui/request/_superseded_by_message.html.haml b/src/api/app/views/webui/request/_superseded_by_message.html.haml
@@ -3,11 +3,10 @@
     .ui-state-info.ui-corner-all.ui-widget-shadow.padding-10pt#request-supersedes-hint
       %span.ui-icon.ui-icon-info
         This request supersedes:
-        - superseding.each_with_index do |bs_request, index|
+        - superseding.each do |bs_request|
           = link_to "request #{bs_request.number}", request_show_path(number: bs_request.number)
-          = succeed (', ' if index < superseding.length - 1) do
-            = surround '(', ')' do
-              = link_to('Show diff', request_show_path(number: bs_request.superseded_by, diff_to_superseded: bs_request.number))
+          = surround '(', ")#{', ' unless bs_request == superseding.last }" do
+            = link_to('Show diff', request_show_path(number: bs_request.superseded_by, diff_to_superseded: bs_request.number))
 - if superseded_by.present?
   .grid_16.alpha.omega.box-invisible
     .ui-state-info.ui-corner-all.ui-widget-shadow.padding-10pt#request-superseded-by-hint