Use strings instead of constans to get rid of circular dependencies

src/api/app/models/decision.rb

@@ -1,5 +1,5 @@
 class Decision < ApplicationRecord
-  TYPES = [::DecisionFavored, ::DecisionCleared].freeze
+  TYPES = %w[DecisionFavored DecisionCleared].freeze
 
   validates :reason, presence: true, length: { maximum: 65_535 }
   validates :type, presence: true, length: { maximum: 255 }
@@ -23,7 +23,8 @@ def description
 
   # List of all viable types for a reportable, used in the decision creation form
   def self.types(reportable)
-    TYPES.filter_map do |decision_type|
+    TYPES.filter_map do |decision_type_name|
+      decision_type = decision_type_name.constantize
       [decision_type.display_name, decision_type.name] if decision_type.display?(reportable)
     end.compact.to_h
   end

src/api/lib/tasks/dev/reports.rake

@@ -55,7 +55,7 @@ namespace :dev do
 
       Report.find_each do |report|
         # Reports with even id will be 'cleared' (0). Those with odd id will be 'favor' (1).
-        Decision.create!(reason: "Just because! #{report.id}", moderator: admin, type: Decision::TYPES[(report.id % 2)].name, reports: [report])
+        Decision.create!(reason: "Just because! #{report.id}", moderator: admin, type: Decision::TYPES[(report.id % 2)], reports: [report])
       end
 
       # The same decision applies to more than one report about the same object/reportable.

src/api/spec/components/notification_action_description_component_spec.rb

@@ -1,5 +1,3 @@
-require 'decision' # To break the circular dependency between Decision and DecisionFavored and DecisionCleared
-
 RSpec.describe NotificationActionDescriptionComponent, type: :component do
   context 'when the notification is for a Event::RequestStatechange event with a request having only a target' do
     let(:target_project) { create(:project, name: 'project_123') }