Skip to content

Commit

Permalink
Rename Token#name to Token#description
Browse files Browse the repository at this point in the history
  • Loading branch information
vpereira committed Apr 19, 2022
1 parent 33ccd2a commit abfc5ce
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/api/app/models/token.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ class Token < ApplicationRecord
has_secure_token :string

before_validation do
self.name ||= ''
self.description ||= ''
end

validates :name, length: { maximum: 64 }
validates :description, length: { maximum: 64 }
validates :string, uniqueness: { case_sensitive: false }
validates :scm_token, absence: true, if: -> { type != 'Token::Workflow' }

Expand Down Expand Up @@ -63,7 +63,7 @@ def set_triggered_at
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
2 changes: 1 addition & 1 deletion src/api/app/models/token/rebuild.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def package_find_options
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
2 changes: 1 addition & 1 deletion src/api/app/models/token/release.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def package_find_options
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
2 changes: 1 addition & 1 deletion src/api/app/models/token/rss.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Token::Rss < Token
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
2 changes: 1 addition & 1 deletion src/api/app/models/token/service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def package_find_options
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
2 changes: 1 addition & 1 deletion src/api/app/models/token/workflow.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def validation_errors
# Table name: tokens
#
# id :integer not null, primary key
# name :string(64) default("")
# description :string(64) default("")
# scm_token :string(255) indexed
# string :string(255) indexed
# triggered_at :datetime
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
class RenameNameToDescriptionInTokens < ActiveRecord::Migration[6.1]
def up
# rename column is safe in mysql 5.6 and beyond
# check https://stefan.magnuson.co/posts/2020-04-18-zero-downtime-migrations-with-rails-and-mysql/
safety_assured { rename_column :tokens, :name, :description }
end

def down
safety_assured { rename_column :tokens, :description, :name }
end
end
6 changes: 5 additions & 1 deletion src/api/db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
#
# It's strongly recommended that you check this file into your version control system.

<<<<<<< HEAD
ActiveRecord::Schema.define(version: 2022_04_13_223300) do
=======
ActiveRecord::Schema.define(version: 2022_04_12_090435) do
>>>>>>> d53ec94603 (Rename Token#name to Token#description)

create_table "architectures", id: :integer, charset: "utf8mb4", collation: "utf8mb4_unicode_ci", options: "ENGINE=InnoDB ROW_FORMAT=DYNAMIC", force: :cascade do |t|
t.string "name", null: false, collation: "utf8_general_ci"
Expand Down Expand Up @@ -1012,7 +1016,7 @@
t.integer "package_id"
t.string "type", collation: "utf8_unicode_ci"
t.string "scm_token"
t.string "name", limit: 64, default: ""
t.string "description", limit: 64
t.datetime "triggered_at"
t.index ["package_id"], name: "package_id"
t.index ["scm_token"], name: "index_tokens_on_scm_token"
Expand Down

0 comments on commit abfc5ce

Please sign in to comment.