Auto-correct RuboCop offenses for RSpec/ItBehavesLike - spec/controllers

Cassettes had to be renamed to follow the changes.
openSUSE · Jun 9, 2020 · ac8636f · ac8636f
1 parent 0756da6
commit ac8636f
Show file tree

Hide file tree

Showing 22 changed files with 10 additions and 13 deletions.
diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml
@@ -296,9 +296,6 @@ RSpec/InstanceVariable:
 # SupportedStyles: it_behaves_like, it_should_behave_like
 RSpec/ItBehavesLike:
   Exclude:
-    - 'spec/controllers/person_controller_spec.rb'
-    - 'spec/controllers/webui/package_controller_spec.rb'
-    - 'spec/controllers/webui/project_controller_spec.rb'
     - 'spec/helpers/webui/package_helper_spec.rb'
     - 'spec/models/bs_request_action_spec.rb'
     - 'spec/models/bs_request_spec.rb'

diff --git a/...e_build_log/successfully/1_10_1_1_1_1.yml → ...e_build_log/successfully/1_10_1_1_1_1.yml b/...e_build_log/successfully/1_10_1_1_1_1.yml → ...e_build_log/successfully/1_10_1_1_1_1.yml
diff --git a/...hich_name_that_includes_/1_10_1_1_2_1.yml → ...hich_name_that_includes_/1_10_1_1_2_1.yml b/...hich_name_that_includes_/1_10_1_1_2_1.yml → ...hich_name_that_includes_/1_10_1_1_2_1.yml
diff --git a/...hich_name_that_includes_/1_10_1_1_3_1.yml → ...hich_name_that_includes_/1_10_1_1_3_1.yml b/...hich_name_that_includes_/1_10_1_1_3_1.yml → ...hich_name_that_includes_/1_10_1_1_3_1.yml
diff --git a/...h_a_non_existant_package/1_10_1_1_5_1.yml → ...h_a_non_existant_package/1_10_1_1_5_1.yml b/...h_a_non_existant_package/1_10_1_1_5_1.yml → ...h_a_non_existant_package/1_10_1_1_5_1.yml
diff --git a/...h_a_non_existant_package/1_10_1_1_5_2.yml → ...h_a_non_existant_package/1_10_1_1_5_2.yml b/...h_a_non_existant_package/1_10_1_1_5_2.yml → ...h_a_non_existant_package/1_10_1_1_5_2.yml
diff --git a/...h_a_non_existant_project/1_10_1_1_6_1.yml → ...h_a_non_existant_project/1_10_1_1_6_1.yml b/...h_a_non_existant_project/1_10_1_1_6_1.yml → ...h_a_non_existant_project/1_10_1_1_6_1.yml
diff --git a/...h_a_non_existant_project/1_10_1_1_6_2.yml → ...h_a_non_existant_project/1_10_1_1_6_2.yml b/...h_a_non_existant_project/1_10_1_1_6_2.yml → ...h_a_non_existant_project/1_10_1_1_6_2.yml
diff --git a/...with_a_protected_package/1_10_1_1_4_1.yml → ...with_a_protected_package/1_10_1_1_4_1.yml b/...with_a_protected_package/1_10_1_1_4_1.yml → ...with_a_protected_package/1_10_1_1_4_1.yml
diff --git a/...with_a_protected_package/1_10_1_1_4_2.yml → ...with_a_protected_package/1_10_1_1_4_2.yml b/...with_a_protected_package/1_10_1_1_4_2.yml → ...with_a_protected_package/1_10_1_1_4_2.yml
diff --git a/...e_build_log/successfully/1_10_2_1_1_1.yml → ...e_build_log/successfully/1_10_2_1_1_1.yml b/...e_build_log/successfully/1_10_2_1_1_1.yml → ...e_build_log/successfully/1_10_2_1_1_1.yml
diff --git a/...hich_name_that_includes_/1_10_2_1_2_1.yml → ...hich_name_that_includes_/1_10_2_1_2_1.yml b/...hich_name_that_includes_/1_10_2_1_2_1.yml → ...hich_name_that_includes_/1_10_2_1_2_1.yml
diff --git a/...hich_name_that_includes_/1_10_2_1_3_1.yml → ...hich_name_that_includes_/1_10_2_1_3_1.yml b/...hich_name_that_includes_/1_10_2_1_3_1.yml → ...hich_name_that_includes_/1_10_2_1_3_1.yml
diff --git a/...h_a_non_existant_package/1_10_2_1_5_1.yml → ...h_a_non_existant_package/1_10_2_1_5_1.yml b/...h_a_non_existant_package/1_10_2_1_5_1.yml → ...h_a_non_existant_package/1_10_2_1_5_1.yml
diff --git a/...h_a_non_existant_package/1_10_2_1_5_2.yml → ...h_a_non_existant_package/1_10_2_1_5_2.yml b/...h_a_non_existant_package/1_10_2_1_5_2.yml → ...h_a_non_existant_package/1_10_2_1_5_2.yml
diff --git a/...h_a_non_existant_project/1_10_2_1_6_1.yml → ...h_a_non_existant_project/1_10_2_1_6_1.yml b/...h_a_non_existant_project/1_10_2_1_6_1.yml → ...h_a_non_existant_project/1_10_2_1_6_1.yml
diff --git a/...h_a_non_existant_project/1_10_2_1_6_2.yml → ...h_a_non_existant_project/1_10_2_1_6_2.yml b/...h_a_non_existant_project/1_10_2_1_6_2.yml → ...h_a_non_existant_project/1_10_2_1_6_2.yml
diff --git a/...with_a_protected_package/1_10_2_1_4_1.yml → ...with_a_protected_package/1_10_2_1_4_1.yml b/...with_a_protected_package/1_10_2_1_4_1.yml → ...with_a_protected_package/1_10_2_1_4_1.yml
diff --git a/...with_a_protected_package/1_10_2_1_4_2.yml → ...with_a_protected_package/1_10_2_1_4_2.yml b/...with_a_protected_package/1_10_2_1_4_2.yml → ...with_a_protected_package/1_10_2_1_4_2.yml
diff --git a/src/api/spec/controllers/person_controller_spec.rb b/src/api/spec/controllers/person_controller_spec.rb
@@ -132,15 +132,15 @@
           login admin_user
         end
 
-        it_should_behave_like 'not allowed to change user details'
+        it_behaves_like 'not allowed to change user details'
       end
 
       context 'as a user' do
         before do
           login user
         end
 
-        it_should_behave_like 'not allowed to change user details'
+        it_behaves_like 'not allowed to change user details'
       end
     end
   end

diff --git a/src/api/spec/controllers/webui/package_controller_spec.rb b/src/api/spec/controllers/webui/package_controller_spec.rb
@@ -721,7 +721,7 @@ def do_request(params)
         get :live_build_log, params: params
       end
 
-      it_should_behave_like 'build log'
+      it_behaves_like 'build log'
 
       context 'with a nonexistant repository' do
         before do
@@ -789,7 +789,7 @@ def do_request(params)
         get :update_build_log, params: params, xhr: true
       end
 
-      it_should_behave_like 'build log'
+      it_behaves_like 'build log'
 
       context 'with a nonexistant repository' do
         before do

diff --git a/src/api/spec/controllers/webui/project_controller_spec.rb b/src/api/spec/controllers/webui/project_controller_spec.rb
@@ -414,7 +414,7 @@
 
       it { expect(assigns(:project).name).to eq("#{user.home_project_name}:my_project") }
 
-      it_should_behave_like 'a valid project saved'
+      it_behaves_like 'a valid project saved'
     end
 
     context 'with a param called maintenance_project' do
@@ -424,7 +424,7 @@
 
       it { expect(assigns(:project).kind).to eq('maintenance') }
 
-      it_should_behave_like 'a valid project saved'
+      it_behaves_like 'a valid project saved'
     end
 
     context 'with a param that disables a flag' do
@@ -436,12 +436,12 @@
         it { expect(assigns(:project).flags.first.flag).to eq(flag_name) }
         it { expect(assigns(:project).flags.find_by(flag: flag_name).status).to eq('disable') }
 
-        it_should_behave_like 'a valid project saved'
+        it_behaves_like 'a valid project saved'
       end
 
-      it_should_behave_like 'a param that creates a disabled flag', :access_protection, 'access'
-      it_should_behave_like 'a param that creates a disabled flag', :source_protection, 'sourceaccess'
-      it_should_behave_like 'a param that creates a disabled flag', :disable_publishing, 'publish'
+      it_behaves_like 'a param that creates a disabled flag', :access_protection, 'access'
+      it_behaves_like 'a param that creates a disabled flag', :source_protection, 'sourceaccess'
+      it_behaves_like 'a param that creates a disabled flag', :disable_publishing, 'publish'
     end
 
     context 'with an invalid project data' do