Skip to content

Commit

Permalink
[ci] Migrate branching tests for non existing source projects and pac…
Browse files Browse the repository at this point in the history
…kages to rspec
  • Loading branch information
bgeuken committed May 31, 2016
1 parent 8844fa1 commit aff1d66
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 4 deletions.
18 changes: 18 additions & 0 deletions src/api/spec/controllers/webui/package_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,22 @@
it { expect(source_package.reload.description).to eq('New description for package') }
it { expect(response).to redirect_to(package_show_path(project: source_project, package: source_package)) }
end

describe "POST #save_new_link" do
before do
login(user)
end

it "shows an error if source package doesn't exist" do
post :save_new_link, project: user.home_project, linked_project: source_project
expect(flash[:error]).to eq("Failed to branch: Package does not exist.")
expect(response).to redirect_to(root_path)
end

it "shows an error if source project doesn't exist" do
post :save_new_link, project: user.home_project
expect(flash[:error]).to eq("Failed to branch: Package does not exist.")
expect(response).to redirect_to(root_path)
end
end
end
8 changes: 4 additions & 4 deletions src/api/test/functional/webui/package_branch_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def test_branch_package_twice # spec/features/webui/projects_spec.rb
:original_project => 'kde4')
end

def test_branch_empty_package_name
def test_branch_empty_package_name # spec/controllers/webui/package_controller_spec.rb
login_Iggy to: project_show_path(:project => @project)

create_package_branch(
Expand All @@ -145,7 +145,7 @@ def test_branch_empty_package_name
:expect => :invalid_package_name)
end

def test_branch_empty_project_name
def test_branch_empty_project_name # spec/controllers/webui/package_controller_spec.rb
login_Iggy to: project_show_path(:project => @project)

create_package_branch(
Expand All @@ -155,7 +155,7 @@ def test_branch_empty_project_name
:expect => :invalid_project_name)
end

def test_branch_package_name_with_spaces
def test_branch_package_name_with_spaces # spec/controllers/webui/package_controller_spec.rb
login_Iggy to: project_show_path(:project => @project)

create_package_branch(
Expand All @@ -165,7 +165,7 @@ def test_branch_package_name_with_spaces
:expect => :invalid_package_name)
end

def test_branch_project_name_with_spaces
def test_branch_project_name_with_spaces # spec/controllers/webui/package_controller_spec.rb
login_Iggy to: project_show_path(:project => @project)

create_package_branch(
Expand Down

0 comments on commit aff1d66

Please sign in to comment.