[webui] make gravatar usage optional since it is a potential privacy …

…issue.

src/webui/app/controllers/home_controller.rb

@@ -16,20 +16,22 @@ def icon
     Rails.cache.delete(key) if discard_cache?
     content = Rails.cache.fetch(key, :expires_in => 5.hour) do
 
-      email = Person.email_for_login(user)
-      hash = Digest::MD5.hexdigest(email.downcase)
-      http = Net::HTTP.new("www.gravatar.com")
-      begin
-        http.start
-        response = http.get "/avatar/#{hash}?s=#{size}&d=wavatar" unless Rails.env.test?
-        if response.is_a?(Net::HTTPSuccess)
-          content = response.body
+      unless CONFIG['enable_gravatar'] == :off
+        email = Person.email_for_login(user)
+        hash = Digest::MD5.hexdigest(email.downcase)
+        http = Net::HTTP.new("www.gravatar.com")
+        begin
+          http.start
+          response = http.get "/avatar/#{hash}?s=#{size}&d=wavatar" unless Rails.env.test?
+          if response.is_a?(Net::HTTPSuccess)
+            content = response.body
+          end
+        rescue SocketError, Errno::EINTR, Errno::EPIPE, EOFError, Net::HTTPBadResponse, IOError, Errno::ETIMEDOUT, Errno::ECONNREFUSED => err
+          logger.debug "#{err} when fetching http://www.gravatar.com/avatar/#{hash}?s=#{size}"
+          http = nil
         end
-      rescue SocketError, Errno::EINTR, Errno::EPIPE, EOFError, Net::HTTPBadResponse, IOError, Errno::ETIMEDOUT, Errno::ECONNREFUSED => err
-	logger.debug "#{err} when fetching http://www.gravatar.com/avatar/#{hash}?s=#{size}"
-        http = nil
+        http.finish if http
       end
-      http.finish if http
 
       unless content
         #TODO/FIXME: Looks like an asset...

src/webui/config/options.yml.example

@@ -53,6 +53,10 @@ exception_recipients: []
 # if the api runs against ldap (:on && :off)
 #frontend_ldap_mode: :on
 
+# enable gravatar icons in webui. This will tell www.gravatar.com the email adresses
+# of your users.
+#enable_gravatar: :off
+
 # hostname of API
 frontend_host: api.opensuse.org
 # port of API