Skip to content

Commit

Permalink
[api] do not send out possible secret rpc answer to user
Browse files Browse the repository at this point in the history
  • Loading branch information
adrianschroeter committed Jan 20, 2012
1 parent e8fdadf commit bae0be3
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/api/app/models/issue_tracker.rb
Expand Up @@ -92,7 +92,7 @@ def update_issues()
self.issues_updated = update_time_stamp
self.save!

return ret
return true
end

def fetch_issues(issues=nil)
Expand All @@ -104,6 +104,7 @@ def fetch_issues(issues=nil)
ids = issues.map{ |x| x.name.to_s }

return private_fetch_issues(ids)
return true
end

private
Expand All @@ -116,6 +117,9 @@ def private_fetch_issues(ids)
update_time_stamp = Time.at(Time.now.to_f)

if kind == "bugzilla"
# limit to 256 ids to avoid too much load and timeouts on bugzilla side
ids=ids[0..256]

begin
result = bugzilla_server.get({:ids => ids, :permissive => 1})
rescue RuntimeError => e
Expand Down

0 comments on commit bae0be3

Please sign in to comment.