Fix IssueTracker validation errors

IssueTracker.create will always return an IssueTracker object, even if it's not valid.
openSUSE · Sep 3, 2021 · bbc8ca5 · bbc8ca5
1 parent 12d15af
commit bbc8ca5
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/api/app/controllers/issue_trackers_controller.rb b/src/api/app/controllers/issue_trackers_controller.rb
@@ -18,17 +18,17 @@ def index
   # POST /issue_trackers
   def create
     xml = Nokogiri::XML(request.raw_post, &:strict).root
-    @issue_tracker = IssueTracker.create(name: xml.xpath('name[1]/text()').to_s,
-                                         kind: xml.xpath('kind[1]/text()').to_s,
-                                         description: xml.xpath('description[1]/text()').to_s,
-                                         regex: xml.xpath('regex[1]/text()').to_s,
-                                         label: xml.xpath('label[1]/text()').to_s,
-                                         url: xml.xpath('url[1]/text()').to_s,
-                                         enable_fetch: xml.xpath('enable-fetch[1]/text()').to_s,
-                                         issues_updated: Time.now,
-                                         show_url: xml.xpath('show-url[1]/text()').to_s)
+    @issue_tracker = IssueTracker.new(name: xml.xpath('name[1]/text()').to_s,
+                                      kind: xml.xpath('kind[1]/text()').to_s,
+                                      description: xml.xpath('description[1]/text()').to_s,
+                                      regex: xml.xpath('regex[1]/text()').to_s,
+                                      label: xml.xpath('label[1]/text()').to_s,
+                                      url: xml.xpath('url[1]/text()').to_s,
+                                      enable_fetch: xml.xpath('enable-fetch[1]/text()').to_s,
+                                      issues_updated: Time.now,
+                                      show_url: xml.xpath('show-url[1]/text()').to_s)
     respond_to do |format|
-      if @issue_tracker
+      if @issue_tracker.save
         format.xml  { render_ok }
       else
         format.xml  { render xml: @issue_tracker.errors, status: :unprocessable_entity }