Merge pull request #1036 from bgeuken/cleanup_sql_query

[api][webui] Make SQL statement more readable by using heredoc

src/api/app/models/channel_binary.rb

@@ -15,10 +15,16 @@ def self.find_by_project_and_package(project, package)
     # find maintained projects filter
     maintained_projects = Project.get_maintenance_project.expand_maintained_projects
 
-    # rubocop:disable Metrics/LineLength
-    # I am not able to construct this with rails in a valid way :/
-    ChannelBinary.find_by_sql(['SELECT channel_binaries.* FROM channel_binaries LEFT JOIN channel_binary_lists ON channel_binary_lists.id = channel_binaries.channel_binary_list_id LEFT JOIN channels ON channel_binary_lists.channel_id = channels.id LEFT JOIN packages ON channels.package_id = packages.id WHERE (channel_binary_lists.project_id = ? and package = ? and packages.project_id IN (?))', project.id, package, maintained_projects])
-    # rubocop:enable Metrics/LineLength
+    # gsub(/\s+/, "") makes sure there are no additional newlines and whitespaces
+    query = <<-SQL.gsub(/\s+/, " ")
+      SELECT channel_binaries.* FROM channel_binaries
+        LEFT JOIN channel_binary_lists ON channel_binary_lists.id = channel_binaries.channel_binary_list_id
+          LEFT JOIN channels ON channel_binary_lists.channel_id = channels.id
+            LEFT JOIN packages ON channels.package_id = packages.id WHERE (
+              channel_binary_lists.project_id = ? and package = ? and packages.project_id IN (?)
+            )
+    SQL
+    ChannelBinary.find_by_sql([query, project.id, package, maintained_projects])
   end
 
   def create_channel_package_into(project, comment=nil)