Merge pull request #10344 from vpereira/refactor_project_ready_to_aut…

…oclean

Refactor method project_ready_to_autoclean?

src/api/app/jobs/project_create_auto_cleanup_requests_job.rb

@@ -50,10 +50,6 @@ def perform
   private
 
   def autoclean_project(prj)
-    # open requests do block the cleanup
-    return if open_requests_count(prj.name).positive?
-
-    # check the time in project attribute
     return unless project_ready_to_autoclean?(prj)
 
     begin
@@ -84,7 +80,9 @@ def create_request(project:, description: DESCRIPTION, cleanup_time: 5)
 
   def project_ready_to_autoclean?(project)
     # project may be locked?
-    return false if project.nil? || project.is_locked?
+    return false if project.is_locked?
+    # open requests do block the cleanup
+    return false if open_requests_count(project.name).positive?
     return false unless project.check_weak_dependencies?
 
     true