Skip to content

Commit

Permalink
WIP Fix trigger controller specs
Browse files Browse the repository at this point in the history
  • Loading branch information
danidoni authored and Dany Marcoux committed Apr 26, 2021
1 parent c3a40db commit c890242
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
1 change: 1 addition & 0 deletions src/api/app/controllers/trigger_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def runservice
# AUTHENTICATION
def set_token
@token = ::TriggerControllerService::TokenExtractor.new(request).call
raise InvalidToken unless @token
end

def validate_gitlab_event
Expand Down
13 changes: 5 additions & 8 deletions src/api/spec/controllers/trigger_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,28 @@
render_views

before do
allow(User).to receive(:session!).and_return(admin)
allow(::TriggerControllerService::TokenExtractor).to receive(:new) {
-> { OpenStruct.new(valid?: true, token: token) }
}
allow_any_instance_of(::TriggerControllerService::TokenExtractor).to receive(:call).and_return(token)
package
end

describe '#rebuild' do
context 'authentication token is invalid' do
before do
allow(::TriggerControllerService::TokenExtractor).to receive(:new) {
-> { OpenStruct.new(valid?: false, token: nil) }
-> { nil }
}
post :rebuild, params: { format: :xml }
post :create, params: { format: :xml }
end

it { expect(response).to have_http_status(:forbidden) }
end

context 'when token is valid and packet rebuild' do
let(:token) { Token::Rebuild.create(user: admin, package: package) }
let!(:token) { Token::Rebuild.create(user: admin, package: package) }

before do
allow(Backend::Api::Sources::Package).to receive(:rebuild).and_return("<status code=\"ok\" />\n")
post :rebuild, params: { format: :xml }
post :create, params: { format: :xml }
end

it { expect(response).to have_http_status(:success) }
Expand Down

0 comments on commit c890242

Please sign in to comment.