Move change devel request javascripts into a file

Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de>
openSUSE · Sep 4, 2018 · c9ee48f · c9ee48f
1 parent b5654dd
commit c9ee48f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/src/api/app/assets/javascripts/webui2/application.js b/src/api/app/assets/javascripts/webui2/application.js
@@ -25,6 +25,7 @@
 //= require webui2/requests_table.js
 
 // FIXME refactor these files
+//= require webui2/autocomplete.js
 //= require webui2/comment.js
 //= require webui2/request.js
 //= require webui2/buildresult.js

diff --git a/src/api/app/assets/javascripts/webui2/autocomplete.js b/src/api/app/assets/javascripts/webui2/autocomplete.js
@@ -0,0 +1,12 @@
+function autocompleteDevelProject(sourcePath) { // jshint ignore:line
+  $("#devel_project").autocomplete({
+    appendTo: '.modal-body',
+    source: sourcePath,
+    search: function(event, ui) { // jshint ignore:line
+      $(this).addClass('loading-spinner');
+    },
+    response: function(event, ui) { // jshint ignore:line
+      $(this).removeClass('loading-spinner');
+    },
+    minLength: 2});
+}
diff --git a/src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml b/src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml
@@ -26,15 +26,4 @@
         = render partial: 'webui2/shared/dialog_action_buttons'
 
 :javascript
-  $("#devel_project").autocomplete({
-    source: '#{url_for controller: 'project', action: 'autocomplete_projects'}',
-    search: function(event, ui) {
-      $(this).addClass('loading-spinner');
-    },
-    response: function(event, ui) {
-      $(this).removeClass('loading-spinner');
-    },
-    minLength: 2});
-
-  $("#devel_project" ).autocomplete( "option", "appendTo", ".modal-body" );
-
+  autocompleteDevelProject('#{autocomplete_projects_path}');
diff --git a/src/api/config/routes.rb b/src/api/config/routes.rb
@@ -237,7 +237,7 @@ def self.public_or_about_path?(request)
       get 'project/list_public' => :index
       get 'project/list_all' => :index, show_all: true
       get 'project/list' => :index
-      get 'project/autocomplete_projects' => :autocomplete_projects
+      get 'project/autocomplete_projects' => :autocomplete_projects, as: 'autocomplete_projects'
       get 'project/autocomplete_incidents' => :autocomplete_incidents
       get 'project/autocomplete_packages' => :autocomplete_packages
       get 'project/autocomplete_repositories' => :autocomplete_repositories