Merge pull request #3034 from bgeuken/rspec_package_controller

Rspec package controller tests and cleanups

src/api/app/controllers/webui/package_controller.rb

@@ -851,14 +851,6 @@ def update_build_log
 
     set_initial_offset if @offset.zero?
 
-    package_object = @project.find_package(params[:package])
-    # remote package sources are always fine to show
-    if package_object && !package_object.check_source_access?
-      flash[:error] = "Could not access revisions"
-      redirect_back(fallback_location: package_show_path(project: @project, package: package_object.name))
-      return
-    end
-
     begin
       chunk = get_log_chunk(@project, @package, @repo, @arch, @offset, @offset + @maxsize)
 

src/api/app/views/webui/package/_live_log_controls.html.erb

@@ -11,7 +11,7 @@
 <% if @can_modify %>
     <p>
       <span class="link_trigger_rebuild hidden">
-      <%= link_to sprited_text('rebuild', 'Trigger Rebuild'), {action: 'trigger_rebuild', project: @project, package: @package, arch: @arch, repository: @repo}, method: :delete %>
+      <%= link_to sprited_text('rebuild', 'Trigger Rebuild'), {action: 'trigger_rebuild', project: @project, package: @package, arch: @arch, repository: @repo}, method: :post %>
     </span>
   <span class="link_abort_build hidden">
       <%= link_to "[Abort build]", action: 'abort_build', project: @project, package: @package, arch: @arch, repository: @repo %>

src/api/app/views/webui/package/binaries.html.erb

@@ -37,7 +37,7 @@
   <% end %>
   <p>
     <% if User.current.can_modify_package? @package %>
-      <%= link_to sprited_text('rebuild', 'Trigger'),{ :controller => :package, :action => :trigger_rebuild, :arch => result['arch'], :project => @project, :package => @package, :repository => @repository }, { :method => :delete} %> rebuild
+      <%= link_to sprited_text('rebuild', 'Trigger'),{ :controller => :package, :action => :trigger_rebuild, :arch => result['arch'], :project => @project, :package => @package, :repository => @repository }, { :method => :post} %> rebuild
 
       <% if result.get('binarylist')['binary'] %>
         <%= link_to sprited_text('drive_burn', 'Delete'), { :controller => :package, :action => :wipe_binaries, :arch => result['arch'], :project => @project, :package => @package, :repository => @repository }, { :method => :delete} %> built binaries

src/api/config/routes.rb

@@ -116,7 +116,6 @@ def self.public_or_about_path?(request)
       post 'package/branch' => :branch, constraints: cons
       post 'package/save/:project/:package' => :save, constraints: cons
       get 'package/delete_dialog/:project/:package' => :delete_dialog, constraints: cons
-      post 'package/trigger_services/:project/:package' => :trigger_services, constraints: cons
       post 'package/remove/:project/:package' => :remove, constraints: cons
       get 'package/add_file/:project/:package' => :add_file, constraints: cons
       post 'package/save_file/:project/:package' => :save_file, constraints: cons
@@ -128,7 +127,8 @@ def self.public_or_about_path?(request)
       get 'package/live_build_log/:project/:package/:repository/:arch' => :live_build_log, constraints: cons, as: 'package_live_build_log'
       get 'package/update_build_log/:project/:package/:repository/:arch' => :update_build_log, constraints: cons
       get 'package/abort_build/:project/:package' => :abort_build, constraints: cons
-      delete 'package/trigger_rebuild/:project/:package' => :trigger_rebuild, constraints: cons
+      post 'package/trigger_services/:project/:package' => :trigger_services, constraints: cons
+      post 'package/trigger_rebuild/:project/:package' => :trigger_rebuild, constraints: cons
       delete 'package/wipe_binaries/:project/:package' => :wipe_binaries, constraints: cons
       get 'package/devel_project/:project/:package' => :devel_project, constraints: cons
       get 'package/buildresult' => :buildresult, constraints: cons