Skip to content

Commit

Permalink
Move group members' table to a partial
Browse files Browse the repository at this point in the history
The show file is a bit more readable now.
  • Loading branch information
saraycp committed Dec 7, 2018
1 parent 7a4d1dc commit cdebf34
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 23 deletions.
23 changes: 23 additions & 0 deletions src/api/app/views/webui2/shared/_group_members_table.html.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
.obs-dataTable
%table.table.table-striped.table-bordered.w-100#group-members-table
%thead
%tr
%th Login Name
%th
%tbody
- if group.users.any?
- group.users.each do |user|
%tr
%td= link_to(user, user_show_path(user))
%td.text-nowrap
= link_to('#', data: { toggle: 'modal', target: "#delete-group-user-#{user.id}-modal" }) do
%i.fas.fa-times-circle.text-danger{ title: "Remove user '#{user}' from '#{group}' group." }
= render(partial: 'remove_user_modal', locals: { group: group, user: user })
- else
%tr
%td{ colspan: 2 } This group does not contain users.
- if policy(group).update?
= link_to('#', class: 'nav-link', data: { toggle: 'modal', target: '#add-user-modal' }, id: 'add-user') do
%i.fas.fa-plus-circle.text-primary
Add User
= render(partial: 'add_user_modal', locals: { group: group })
24 changes: 1 addition & 23 deletions src/api/app/views/webui2/webui/groups/show.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,7 @@

.tab-pane#group-members{ aria: { controls: 'group-members' }, role: 'tabpanel' }
%h3 Group Members
.obs-dataTable
%table.table.table-striped.table-bordered.w-100#group-members-table
%thead
%tr
%th Login Name
%th
%tbody
- if @group.users.any?
- @group.users.each do |user|
%tr
%td= link_to(user, user_show_path(user))
%td.text-nowrap
= link_to('#', data: { toggle: 'modal', target: "#delete-group-user-#{user.id}-modal" }) do
%i.fas.fa-times-circle.text-danger{ title: "Remove user '#{user}' from '#{@group}' group." }
= render(partial: 'remove_user_modal', locals: { group: @group, user: user })
- else
%tr
%td{ colspan: 2 } This group does not contain users.
- if policy(@group).update?
= link_to('#', class: 'nav-link', data: { toggle: 'modal', target: '#add-user-modal' }, id: 'add-user') do
%i.fas.fa-plus-circle.text-primary
Add User
= render(partial: 'add_user_modal', locals: { group: @group })
= render(partial: 'webui2/shared/group_members_table', locals: { group: @group })

= content_for :ready_function do
:plain
Expand Down

0 comments on commit cdebf34

Please sign in to comment.