Move PersonController private methods

Move private methods under `private` keyword to follow best practices.

src/api/app/controllers/person_controller.rb

@@ -220,6 +220,27 @@ def internal_register
     raise e
   end
 
+  def change_my_password
+    authorize @user, :update?
+    # FIXME3.0: remove this function
+    xml = REXML::Document.new(request.raw_post)
+
+    logger.debug("changepasswd XML: #{request.raw_post}")
+
+    login = xml.elements['/userchangepasswd/login'].text
+    password = xml.elements['/userchangepasswd/password'].text
+    login = CGI.unescape(login)
+
+    change_password(login, CGI.unescape(password))
+    render_ok
+  end
+
+  private
+
+  def set_user
+    @user = User.find_by(login: params[:login])
+  end
+
   def update_watchlist(user, xml)
     if xml.get('watchlist').empty?
       projects = [xml.get('project')].flatten
@@ -241,8 +262,6 @@ def update_watchlist(user, xml)
     end
   end
 
-  private :update_watchlist
-
   def update_globalroles(user, xml)
     new_globalroles = []
     xml.elements('globalrole') do |e|
@@ -252,23 +271,6 @@ def update_globalroles(user, xml)
     user.update_globalroles(Role.global.where(title: new_globalroles))
   end
 
-  private :update_globalroles
-
-  def change_my_password
-    authorize @user, :update?
-    # FIXME3.0: remove this function
-    xml = REXML::Document.new(request.raw_post)
-
-    logger.debug("changepasswd XML: #{request.raw_post}")
-
-    login = xml.elements['/userchangepasswd/login'].text
-    password = xml.elements['/userchangepasswd/password'].text
-    login = CGI.unescape(login)
-
-    change_password(login, CGI.unescape(password))
-    render_ok
-  end
-
   def change_password(login, password)
     unless User.session!
       logger.debug 'No user logged in, permission to changing password denied'
@@ -295,11 +297,4 @@ def change_password(login, password)
     @user.password = password
     @user.save!
   end
-  private :change_password
-
-  private
-
-  def set_user
-    @user = User.find_by(login: params[:login])
-  end
 end