[api] Use method parameters instead of instance variables

src/api/app/mixins/request_source_diff.rb

@@ -6,11 +6,8 @@ class ActionSourceDiffer
     attr_accessor :action
 
     def perform(opts)
-      @view_xml = (opts[:view] == 'xml')
-      @withissues = opts[:withissues]
-
       gather_source_packages.map { |spkg|
-        diff_for_source(spkg)
+        diff_for_source(spkg, opts)
       }.join
     end
 
@@ -33,7 +30,7 @@ def gather_source_packages
       end
     end
 
-    def diff_for_source(spkg)
+    def diff_for_source(spkg, options = {})
       @target_project = action.target_project
       @target_package = action.target_package
 
@@ -92,8 +89,8 @@ def diff_for_source(spkg)
         end
       end
       # run diff
-      query[:view] = 'xml' if @view_xml # Request unified diff in full XML view
-      query[:withissues] = 1 if @withissues
+      query[:view] = 'xml' if options[:view] == 'xml' # Request unified diff in full XML view
+      query[:withissues] = 1 if options[:withissues]
       BsRequestAction.get_package_diff(path, query)
     end