Skip to content

Commit

Permalink
[webui] Adding reviews should still only be possible in 'new' or 'rev…
Browse files Browse the repository at this point in the history
…iew'

state.
  • Loading branch information
saschpe committed Mar 12, 2012
1 parent b84babb commit d2883e5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/webui/app/controllers/request_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,11 @@ def show
@is_author = @req.creator().login == session[:login]
@superseded_by = @req.state.value("superseded_by")
@is_target_maintainer = @req.is_target_maintainer?(session[:login])
@can_add_reviews = ['new', 'review'].include?(@state) && (@is_author || @is_target_maintainer)
@can_handle_request = ['new', 'review', 'declined'].include?(@state) && (@is_target_maintainer || @is_author)

@my_open_reviews, @other_open_reviews = @req.reviews_for_user_and_others(@user)
# everyone who is reviewer can also add reviewers
@can_add_reviews ||= @my_open_reviews.length > 0
@can_add_reviews = ['new', 'review'].include?(@state) && (@is_author || @is_target_maintainer || @my_open_reviews.length > 0)
@can_handle_request = ['new', 'review', 'declined'].include?(@state) && (@is_target_maintainer || @is_author)

@events = @req.events()
@actions = @req.actions(!@spider_bot) # Don't fetch diff for spiders, may take to long

Expand Down

0 comments on commit d2883e5

Please sign in to comment.