Update rubocop todo after rubocop/rubcop-performance update

The minor gem update of rubocop and rubocop-performance
introduces new cops which triggers the linter on code
which is already part of the master branch.

src/api/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2020-06-29 08:31:39 UTC using RuboCop version 0.86.0.
+# on 2020-07-09 11:47:59 UTC using RuboCop version 0.87.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -27,6 +27,12 @@ Lint/NonLocalExitFromIterator:
     - 'app/controllers/configurations_controller.rb'
     - 'app/models/patchinfo.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'app/models/relationship.rb'
+
 # Offense count: 5
 Lint/RescueException:
   Exclude:
@@ -74,10 +80,10 @@ Lint/UriEscapeUnescape:
     - 'spec/models/package_spec.rb'
     - 'test/functional/request_controller_test.rb'
 
-# Offense count: 880
+# Offense count: 881
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 202
+  Max: 195
 
 # Offense count: 19
 # Configuration parameters: CountBlocks, Max.
@@ -93,7 +99,7 @@ Metrics/BlockNesting:
     - 'test/node_matcher.rb'
 
 # Offense count: 82
-# Configuration parameters: CountComments, Max.
+# Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ClassLength:
   Exclude:
     - 'app/controllers/application_controller.rb'
@@ -274,13 +280,13 @@ Metrics/CyclomaticComplexity:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/node_matcher.rb'
 
-# Offense count: 926
-# Configuration parameters: CountComments, ExcludedMethods.
+# Offense count: 927
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Max: 227
 
 # Offense count: 5
-# Configuration parameters: CountComments, Max.
+# Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ModuleLength:
   Exclude:
     - 'app/helpers/flag_helper.rb'
@@ -477,7 +483,7 @@ Naming/MethodParameterName:
     - 'test/models/event_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 48
+# Offense count: 49
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_
@@ -540,7 +546,7 @@ RSpec/BeforeAfterAll:
     - 'spec/support/**/*.rb'
     - 'spec/models/relationship_spec.rb'
 
-# Offense count: 772
+# Offense count: 774
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -553,7 +559,7 @@ RSpec/DescribeClass:
     - 'spec/routing/webui/projects/public_key_spec.rb'
     - 'spec/routing/webui/projects/ssl_certificate_spec.rb'
 
-# Offense count: 417
+# Offense count: 418
 # Cop supports --auto-correct.
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
@@ -749,7 +755,7 @@ RSpec/IteratedExpectation:
 RSpec/LeadingSubject:
   Enabled: false
 
-# Offense count: 379
+# Offense count: 374
 RSpec/LetSetup:
   Exclude:
     - 'spec/controllers/cloud/upload_jobs_controller_spec.rb'
@@ -841,7 +847,6 @@ RSpec/LetSetup:
     - 'spec/queries/projects_with_delegate_request_target_finder_spec.rb'
     - 'spec/queries/projects_with_image_templates_finder_spec.rb'
     - 'spec/queries/projects_with_very_important_attribute_finder_spec.rb'
-    - 'spec/services/notification_creator_spec.rb'
     - 'spec/services/package_service/schema_verifier_spec.rb'
     - 'spec/support/shared_examples/features/beta/user_tab.rb'
     - 'spec/support/shared_examples/features/boostrap_flag_tables.rb'
@@ -857,7 +862,7 @@ RSpec/MessageSpies:
     - 'spec/controllers/webui/project_controller_spec.rb'
     - 'spec/models/kiwi/image_spec.rb'
 
-# Offense count: 437
+# Offense count: 436
 # Configuration parameters: Max.
 RSpec/NestedGroups:
   Exclude:
@@ -938,7 +943,6 @@ RSpec/NestedGroups:
     - 'spec/models/user_ldap_strategy_spec.rb'
     - 'spec/models/user_spec.rb'
     - 'spec/requests/kerberos_login_spec.rb'
-    - 'spec/services/notification_creator_spec.rb'
     - 'spec/services/staging/staging_project_creator_spec.rb'
 
 # Offense count: 2
@@ -1155,7 +1159,7 @@ Rails/OutputSafety:
     - 'app/helpers/webui/user_helper.rb'
     - 'app/helpers/webui/webui_helper.rb'
 
-# Offense count: 12
+# Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: **/Rakefile, **/*.rake
@@ -1255,18 +1259,29 @@ Rails/UniqueValidationWithoutIndex:
     - 'app/models/role.rb'
     - 'app/models/status_message_acknowledgement.rb'
 
-# Offense count: 111
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'app/models/event/base.rb'
+    - 'app/models/history_element/base.rb'
+
+# Offense count: 113
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 14
 Style/ClassVars:
   Exclude:
     - 'app/models/user.rb'
     - 'app/models/user_ldap_strategy.rb'
+    - 'spec/models/user_ldap_strategy_spec.rb'
+    - 'spec/support/shared_contexts/setup_ldap_mock.rb'
     - 'test/functional/branch_publish_flag_test.rb'
     - 'test/test_helper.rb'
 
@@ -1334,11 +1349,18 @@ Style/ConditionalAssignment:
     - 'spec/support/database_cleaner.rb'
     - 'test/functional/source_controller_test.rb'
 
-# Offense count: 837
+# Offense count: 841
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1421
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'config.ru'
+    - 'script/import_database.rb'
+
+# Offense count: 1428
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1513,6 +1535,13 @@ Style/NumericPredicate:
     - 'script/delayed_job_stats.rb'
     - 'test/unit/package_test.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantAssignment:
+  Exclude:
+    - 'app/helpers/maintenance_helper.rb'
+    - 'app/models/maintenance_incident.rb'
+
 # Offense count: 52
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
@@ -1647,7 +1676,7 @@ Style/SymbolArray:
 Style/WordArray:
   Enabled: false
 
-# Offense count: 1822
+# Offense count: 1823
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https