Move logic away from the view, do it in a component method instead

openSUSE · Jul 28, 2023 · d662f1d · d662f1d
1 parent d142c45
commit d662f1d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/api/app/components/workflow_run_filter_link_component.html.haml b/src/api/app/components/workflow_run_filter_link_component.html.haml
@@ -1,8 +1,7 @@
 = link_to(token_workflow_runs_path(@token, @filter_item),
           class: "list-group-item list-group-item-action #{css_for_link} d-flex justify-content-between") do
   %span
-    - if @icon != ''
-      %i.me-1{ class: "#{@icon} #{css_for_icon}" }
+    = icon_tag
     = @text
   - if @amount.positive?
     %span= @amount
diff --git a/src/api/app/components/workflow_run_filter_link_component.rb b/src/api/app/components/workflow_run_filter_link_component.rb
@@ -14,8 +14,8 @@ def css_for_link
     workflow_run_filter_matches? ? 'active' : ''
   end
 
-  def css_for_icon
-    workflow_run_filter_matches? ? 'text-light' : ''
+  def icon_tag
+    tag.i(class: ['me-1', @icon, ('text-light' if workflow_run_filter_matches?)]) if @icon != ''
   end
 
   private