[webui] Validate arch in PackageController#dependency

Missing validation was causing plenty of uncatched xml validation errors: http://errbit-opensuse.herokuapp.com/apps/5620ca2bdc71fa00b1000000/problems/5747e2953caa77000b00002d http://errbit-opensuse.herokuapp.com/apps/5620ca2bdc71fa00b1000000/problems/5747e3e73caa77000600011e http://errbit-opensuse.herokuapp.com/apps/5620ca2bdc71fa00b1000000/problems/5747e2953caa77000b00002d
openSUSE · May 27, 2016 · d66e387 · d66e387
1 parent 21b5f1b
commit d66e387
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/api/app/controllers/webui/package_controller.rb b/src/api/app/controllers/webui/package_controller.rb
@@ -105,7 +105,13 @@ def linking_packages
   end
 
   def dependency
-    @arch = params[:arch]
+    if Architecture.archcache.include?(params[:arch])
+      @arch = params[:arch]
+    else
+      flash[:error] = "Architecture '#{params[:arch]}' is invalid."
+      redirect_back_or_to project_show_path(project: params[:dproject])
+      return
+    end
     @repository = params[:repository]
     @drepository = params[:drepository]
     @dproject = params[:dproject]