Fix Style/StringConcatenation rubocop offense in test/test_helper

openSUSE · Apr 17, 2023 · d8e2c11 · d8e2c11
1 parent 7c9f401
commit d8e2c11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/api/.rubocop.yml b/src/api/.rubocop.yml
@@ -342,7 +342,6 @@ Style/StringConcatenation:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/integration/last_events_test.rb'
     - 'test/test_consistency_helper.rb'
-    - 'test/test_helper.rb'
     - 'test/unit/attrib_test.rb'
     - 'test/unit/attribute_test.rb'
     - 'test/unit/binary_release.rb'

diff --git a/src/api/test/test_helper.rb b/src/api/test/test_helper.rb
@@ -212,7 +212,7 @@ def login_king(opts = {})
 
     teardown do
       dirpath = Rails.root.join('tmp', 'capybara')
-      htmlpath = dirpath.join(name + '.html')
+      htmlpath = dirpath.join("#{name}.html")
       if !passed?
         Dir.mkdir(dirpath) unless Dir.exist?(dirpath)
         save_page(htmlpath)
@@ -254,7 +254,8 @@ def basic_auth
     end
 
     def prepare_request_with_user(user, passwd)
-      @@auth = 'Basic ' + Base64.encode64(user + ':' + passwd)
+      basic_auth_credentials = "#{user}:#{passwd}"
+      @@auth = "Basic #{Base64.encode64(basic_auth_credentials)}"
     end
 
     # will provide a user without special permissions