[api] improve the ruby dialect, refactored variable index, using each…

…_with_index method

src/api/app/models/buildresult.rb

@@ -5,24 +5,22 @@ class Buildresult < ActiveXML::Node
   @@status_hash = nil
 
   def self.avail_status_values
-    return Avail_status_values
+    Avail_status_values
   end
 
   def self.code2index(code)
     unless @@status_hash
-      index = 0
       @@status_hash = Hash.new
-      Avail_status_values.each do |s|
+      Avail_status_values.each_with_index do |s,index|
         @@status_hash[s] = index
-        index += 1
       end
     end
     raise ArgumentError, "code '#{code}' unknown #{@@status_hash.inspect}" unless @@status_hash[code]
-    return @@status_hash[code]
+    @@status_hash[code]
   end
 
   def self.index2code(index)
-    return Avail_status_values[index]
+    Avail_status_values[index]
   end
 
 end

src/api/app/models/channel_binary.rb

@@ -16,7 +16,7 @@ def self.find_by_project_and_package(project, package)
     maintained_projects = Project.get_maintenance_project.expand_maintained_projects
 
     # I am not able to construct this with rails in a valid way :/
-    return ChannelBinary.find_by_sql(['SELECT channel_binaries.* FROM channel_binaries LEFT JOIN channel_binary_lists ON channel_binary_lists.id = channel_binaries.channel_binary_list_id LEFT JOIN channels ON channel_binary_lists.channel_id = channels.id LEFT JOIN packages ON channels.package_id = packages.id WHERE (channel_binary_lists.project_id = ? and package = ? and packages.project_id IN (?))', project.id, package, maintained_projects])
+    ChannelBinary.find_by_sql(['SELECT channel_binaries.* FROM channel_binaries LEFT JOIN channel_binary_lists ON channel_binary_lists.id = channel_binaries.channel_binary_list_id LEFT JOIN channels ON channel_binary_lists.channel_id = channels.id LEFT JOIN packages ON channels.package_id = packages.id WHERE (channel_binary_lists.project_id = ? and package = ? and packages.project_id IN (?))', project.id, package, maintained_projects])
   end
 
   def create_channel_package_into(project)