Merge pull request #10062 from saraycp/rubocop_autocorrect_IV_views

Correct Rubocop Style/ConditionalAssignment in views III

src/api/.rubocop_todo.yml

@@ -1244,10 +1244,6 @@ Style/CommentedKeyword:
 Style/ConditionalAssignment:
   Exclude:
     - 'app/models/bs_request_action_submit.rb'
-    - 'app/views/message/_messages.xml.builder'
-    - 'app/views/models/_project.xml.builder'
-    - 'app/views/models/_remote_project.xml.builder'
-    - 'app/views/models/staging/_staging_project.xml.builder'
     - 'config/initializers/02_apiversion.rb'
     - 'config/initializers/airbrake.rb'
     - 'lib/rabbitmq_bus.rb'

src/api/app/views/message/_messages.xml.builder

@@ -9,8 +9,8 @@ xml.messages(root_attrs) do
     attrs[:severity] = msg.severity || 0
     attrs[:sent_at] = msg.sent_at.xmlschema if msg.sent_at
     attrs[:user] =  msg.user.login if msg.user
-    msg.send_mail ? attrs[:send_mail] = true : attrs[:send_mail] = false
-    msg.private ? attrs[:private] = true : attrs[:private] = false
+    attrs[:send_mail] = msg.send_mail
+    attrs[:private] = msg.private
 
     xml.message(
       msg.text,

src/api/app/views/models/_project.xml.builder

@@ -50,11 +50,11 @@ xml.project(project_attributes) do
       end
       xml_repository.hostsystem(project: repo.hostsystem.project.name, repository: repo.hostsystem.name) if repo.hostsystem
       repo.path_elements.includes(:link).each do |pe|
-        if pe.link.remote_project_name.present?
-          project_name = pe.link.project.name + ':' + pe.link.remote_project_name
-        else
-          project_name = pe.link.project.name
-        end
+        project_name = if pe.link.remote_project_name.present?
+                         pe.link.project.name + ':' + pe.link.remote_project_name
+                       else
+                         pe.link.project.name
+                       end
         xml_repository.path(project: project_name, repository: pe.link.name)
       end
       repo.repository_architectures.joins(:architecture).pluck('architectures.name').each do |arch|