Skip to content

Commit

Permalink
[api] Remove unused parameters from diff_for_source method
Browse files Browse the repository at this point in the history
That method was already defaulting to the action's target project
and package. Thus there is no need to explicitly set it via the
method's parameters.
  • Loading branch information
bgeuken committed Jul 19, 2015
1 parent 3f9635b commit e11b651
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/api/app/mixins/request_source_diff.rb
Expand Up @@ -10,7 +10,7 @@ def perform(opts)
@withissues = opts[:withissues]

gather_source_packages.map { |spkg|
diff_for_source(spkg, action.target_project, action.target_package)
diff_for_source(spkg)
}.join
end

Expand All @@ -33,9 +33,9 @@ def gather_source_packages
end
end

def diff_for_source(spkg, target_project=nil, target_package=nil)
@target_project = target_project || action.target_project
@target_package = target_package || action.target_package
def diff_for_source(spkg)
@target_project = action.target_project
@target_package = action.target_package

# fallback name as last resort
@target_package ||= action.source_package
Expand Down

0 comments on commit e11b651

Please sign in to comment.