Use instance variables for reports and reportable name

openSUSE · Sep 21, 2023 · ebff696 · ebff696
1 parent b6caa48
commit ebff696
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/api/app/components/reports_notice_component.html.haml b/src/api/app/components/reports_notice_component.html.haml
@@ -1,6 +1,6 @@
 .text-warning
   %i.fas.fa-flag
   - if by_user?
-    You reported this #{reportable.class.name.downcase}.
+    You reported this #{reportable_name}.
   - else
-    This #{reportable.class.name.downcase} has #{pluralize(reports.count, 'report')}.
+    This #{reportable_name} has #{report_amount}.
diff --git a/src/api/app/components/reports_notice_component.rb b/src/api/app/components/reports_notice_component.rb
@@ -1,19 +1,21 @@
 class ReportsNoticeComponent < ApplicationComponent
-  attr_reader :reportable, :user
+  attr_reader :reportable, :reportable_name, :user, :reports
 
   def initialize(reportable:, user:)
     super
 
     @reportable = reportable
+    @reportable_name = reportable.class.name.downcase
     @user = user
+    @reports = reportable&.reports
   end
 
   def by_user?
     Report.exists?(user:, reportable:)
   end
 
-  def reports
-    reportable&.reports
+  def report_amount
+    pluralize(reports.count, 'report')
   end
 
   def render?