Skip to content

Commit

Permalink
[api] IssueTracker.update_all_issues uses ActiveJob
Browse files Browse the repository at this point in the history
  • Loading branch information
evanrolfe committed Aug 1, 2017
1 parent 9e8a189 commit ee6a516
Show file tree
Hide file tree
Showing 5 changed files with 108 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/api/app/jobs/issue_tracker_update_issues_job.rb
@@ -0,0 +1,7 @@
class IssueTrackerUpdateIssuesJob < ApplicationJob
queue_as :issuetracking

def perform(issue_tracker_id)
IssueTracker.find(issue_tracker_id).update_issues
end
end
2 changes: 1 addition & 1 deletion src/api/app/models/issue_tracker.rb
Expand Up @@ -171,7 +171,7 @@ def fetch_issues(issues = nil)
def self.update_all_issues
IssueTracker.all.each do |t|
next unless t.enable_fetch
t.delay(queue: "issuetracking").update_issues
IssueTrackerUpdateIssuesJob.perform_later(t.id)
end
end

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions src/api/spec/jobs/issue_tracker_update_issues_job_spec.rb
@@ -0,0 +1,20 @@
require 'rails_helper'

RSpec.describe IssueTrackerUpdateIssuesJob, type: :job, vcr: true do
include ActiveJob::TestHelper

describe '#perform' do
let(:issue_tracker) { double(IssueTracker, id: 1) }

before do
allow(IssueTracker).to receive(:find).and_return(issue_tracker)
allow(issue_tracker).to receive(:update_issues)
end

subject! { IssueTrackerUpdateIssuesJob.new.perform(issue_tracker.id) }

it 'updates the issues' do
expect(issue_tracker).to have_received(:update_issues)
end
end
end
10 changes: 10 additions & 0 deletions src/api/spec/models/issue_tracker_spec.rb
Expand Up @@ -8,4 +8,14 @@
expect { subject }.to have_enqueued_job(IssueTrackerWriteToBackendJob)
end
end

describe '.update_all_issues' do
let!(:issue_tracker) { create(:issue_tracker, enable_fetch: true) }

subject { IssueTracker.update_all_issues }

it 'queues a job' do
expect { subject }.to have_enqueued_job(IssueTrackerUpdateIssuesJob).with(issue_tracker.id)
end
end
end

0 comments on commit ee6a516

Please sign in to comment.