Correct Rubocop Style/RedundantReturn when returning without arguments

src/api/app/controllers/attribute_controller.rb

@@ -68,6 +68,6 @@ def validate_xml
 
     render_error status: 400, errorcode: 'illegal_request',
                  message: "Illegal request: PUT/POST #{request.path}: path does not match content"
-    return
+    nil
   end
 end

src/api/app/controllers/build/file_controller.rb

@@ -43,7 +43,7 @@ def destroy
                      message: 'Delete operation of build results is not allowed'
       end
 
-      return
+      nil
     end
 
     private
@@ -76,7 +76,7 @@ def check_user_has_permission
 
       render_error status: 403, errorcode: 'download_binary_no_permission',
                    message: "No permission to download binaries from package #{params[:package]}, project #{params[:project]}"
-      return
+      nil
     end
 
     def path

src/api/app/controllers/build_controller.rb

@@ -28,7 +28,7 @@ def project_index
 
     if request.get?
       pass_to_backend
-      return
+      nil
     elsif request.post?
       # check if user has project modify rights
       allowed = false
@@ -78,19 +78,19 @@ def project_index
       end
 
       pass_to_backend
-      return
+      nil
     elsif request.put?
       if User.admin_session?
         pass_to_backend
       else
         render_error status: 403, errorcode: 'execute_cmd_no_permission',
                      message: "No permission to execute command on project #{params[:project]}"
       end
-      return
+      nil
     else
       render_error status: 400, errorcode: 'illegal_request',
                    message: "Illegal request: #{request.method.to_s.upcase} #{request.path}"
-      return
+      nil
     end
   end
 

src/api/app/controllers/main_controller.rb

@@ -7,6 +7,6 @@ def index
 
   def notfound
     render_error message: 'Page not found', status: 404, errorcode: 'not_found'
-    return
+    nil
   end
 end

src/api/app/controllers/webui/apidocs_controller.rb

@@ -18,6 +18,6 @@ def file
       flash[:error] = "File not found: #{params[:filename]}"
       redirect_back(fallback_location: { controller: 'apidocs', action: 'index' })
     end
-    return
+    nil
   end
 end

src/api/app/controllers/webui/package_controller.rb

@@ -847,7 +847,7 @@ def find_last_req
         comment: last_req.comment
       }
     end
-    return
+    nil
   end
 
   def get_diff(project, package, options = {})

src/api/app/controllers/webui/request_controller.rb

@@ -237,7 +237,7 @@ def set_superseded_request
     return if @diff_to_superseded
 
     flash[:error] = "Request #{params[:diff_to_superseded]} does not exist or is not superseded by request #{@bs_request.number}."
-    return
+    nil
   end
 
   def require_request

src/api/app/controllers/webui/staging/excluded_requests_controller.rb

@@ -72,7 +72,7 @@ def set_staging_workflow
 
         redirect_back(fallback_location: root_path)
         flash[:error] = 'Staging project not found'
-        return
+        nil
       end
 
       def set_request_exclusion

src/api/app/controllers/webui/staging/projects_controller.rb

@@ -110,7 +110,7 @@ def set_staging_workflow
 
         redirect_back(fallback_location: root_path)
         flash[:error] = 'Staging project not found'
-        return
+        nil
       end
     end
   end

src/api/app/controllers/webui/staging/workflows_controller.rb

@@ -108,7 +108,7 @@ def set_staging_workflow
 
     redirect_back(fallback_location: root_path)
     flash[:error] = "Project #{@project} doesn't have a Staging Workflow associated"
-    return
+    nil
   end
 
   def project_weight(project)

src/api/app/controllers/webui/users_controller.rb

@@ -130,7 +130,7 @@ def change_password
     else
       flash[:error] = 'The value of current password does not match your current password. Please enter the password and try again.'
       redirect_back fallback_location: root_path
-      return
+      nil
     end
   end
 

src/api/app/controllers/webui/webui_controller.rb

@@ -96,7 +96,7 @@ def kerberos_auth
       # Demand kerberos negotiation
       response.headers['WWW-Authenticate'] = 'Negotiate'
       render :new, status: 401
-      return
+      nil
     else
       begin
         authenticator.extract_user

src/api/app/lib/authenticator.rb

@@ -86,7 +86,7 @@ def authorization_infos
     ['X-HTTP_AUTHORIZATION', 'Authorization', 'HTTP_AUTHORIZATION'].each do |header|
       return request.env[header].to_s.split if request.env.key?(header)
     end
-    return
+    nil
   end
 
   private

src/api/app/models/bs_request_action.rb

@@ -719,7 +719,7 @@ def expand_targets(ignore_build_state, ignore_delegate)
              per_package_locking
     end
 
-    return
+    nil
   end
 
   # Follow project links for a target project that delegates requests

src/api/app/models/event/request.rb

@@ -101,7 +101,7 @@ def calculate_diff(a)
       begin
         action.sourcediff(view: nil, withissues: 0)
       rescue BsRequestAction::Errors::DiffError
-        return # can't help
+        nil # can't help
       end
     end
 

src/api/app/models/package.rb

@@ -137,7 +137,7 @@ def self.check_cache(project, package, opts)
 
       Rails.cache.delete(@key) # outdated anyway
     end
-    return
+    nil
   end
 
   def self.internal_get_project(project)

src/api/app/models/project.rb

@@ -326,7 +326,7 @@ def find_remote_project(name, skip_access = false)
           return project, remote_project
         end
       end
-      return
+      nil
     end
 
     # Returns a list of pairs (full name, short name) for each parent
@@ -919,7 +919,7 @@ def find_package(package_name, check_update_project = nil, processed = {})
 
     # no package found
     processed.delete(self)
-    return
+    nil
   end
 
   def expand_all_repositories

src/api/app/models/project_log_entry.rb

@@ -70,7 +70,7 @@ def self.username_from(payload)
       username = User.find_by(id: payload[key]).try(:login) if key == 'commenter'
       return username unless username.blank? || username == 'unknown'
     end
-    return
+    nil
   end
 end
 

src/api/app/models/repository.rb

@@ -56,7 +56,7 @@ def self.find_by_project_and_name(project, repo)
     local_project, remote_project = Project.find_remote_project(project)
     return local_project.repositories.find_or_create_by(name: repo, remote_project_name: remote_project) if local_project
 
-    return
+    nil
   end
 
   def self.find_by_project_and_path(project, path)

src/api/app/models/user.rb

@@ -167,7 +167,7 @@ def self.create_ldap_user(attributes = {})
     return user if user.errors.empty?
 
     logger.info("Cannot create ldap userid: '#{login}' on OBS. Full log: #{user.errors.full_messages.to_sentence}")
-    return
+    nil
   end
 
   # This static method tries to find a user with the given login and password