Skip to content

Commit

Permalink
[ci] Remove comments describing Rubocop cops
Browse files Browse the repository at this point in the history
What the cops does is in the documentation and it could change. So
better not having a comment.

Co-authored-by: Ana María Martínez Gómez <ammartinez@suse.de>
  • Loading branch information
eduardoj and Ana06 committed Jun 22, 2018
1 parent ee16929 commit f2823d2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
13 changes: 0 additions & 13 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,39 +15,29 @@ AllCops:

#################### Layout ###########################

# Align the elements of a hash literal if they span more than one line.
Layout/AlignHash:
# Alignment of entries using hash rocket as separator.
EnforcedHashRocketStyle: table
# Alignment of entries using colon as separator.
EnforcedColonStyle: table
# Select whether hashes that are the last argument in a method call should be
# inspected?
EnforcedLastArgumentHashStyle: ignore_implicit

# We decide disable this cop because we can't reach an agreement
Layout/DotPosition:
Enabled: false

# Align ends correctly.
Layout/EndAlignment:
EnforcedStyleAlignWith: variable

#################### Style ###########################

# Find uses of alias where alias_method would be more appropriate (or is simply preferred due to configuration), and vice versa.
# It also finds uses of alias :symbol rather than alias bareword.
Style/Alias:
EnforcedStyle: 'prefer_alias_method'

# Use ` or %x around command literals.
Style/CommandLiteral:
EnforcedStyle: percent_x

Style/Documentation:
Enabled: false

# Checks for redundant `return` expressions
Style/RedundantReturn:
Enabled: false

Expand All @@ -59,15 +49,12 @@ Style/WordArray:

##################### Metrics ##################################

# Checks if the length a class exceeds some maximum value
Metrics/ClassLength:
Severity: refactor

# Checks the length of lines in the source code.
Metrics/LineLength:
Max: 150
IgnoredPatterns: ['\A#']

# Checks if the length a module exceeds some maximum value
Metrics/ModuleLength:
Severity: refactor
2 changes: 0 additions & 2 deletions src/api/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ AllCops:
Style/GlobalVars:
AllowedVariables: ['$rabbitmq_conn', '$rabbitmq_exchange', '$rabbitmq_channel']

# Checks for chaining of a block after another block that spans multiple lines.
# We disabled this cop because of Rantly.
Style/MultilineBlockChain:
Exclude:
Expand All @@ -41,7 +40,6 @@ Rails:
Rails/DynamicFindBy:
Enabled: false

# Enforces that 'exit' calls are not used.
Rails/Exit:
Exclude:
- 'lib/memory_dumper.rb'
Expand Down

0 comments on commit f2823d2

Please sign in to comment.