Merge pull request #11567 from adrianschroeter/notifications

[api] avoid delivering notifications to unconfirmed users

src/api/app/models/event_subscription/find_for_event.rb

@@ -54,7 +54,7 @@ def filter_and_convert_groups_without_emails_to_users(receivers)
       receivers.each do |receiver|
         case receiver
         when User
-          new_receivers << receiver
+          new_receivers << receiver if receiver.is_active?
 
         when Group
 

src/api/app/models/event_subscription/form.rb

@@ -29,7 +29,7 @@ def update!(subscriptions_params)
     def find_or_initialize_subscription(eventtype, receiver_role, channel)
       opts = { eventtype: eventtype, receiver_role: receiver_role, channel: channel }
 
-      if subscriber.is_a?(User)
+      if subscriber.is_a?(User) && subscriber.is_active?
         opts[:user] = subscriber
       elsif subscriber.is_a?(Group)
         opts[:group] = subscriber

src/api/app/models/group.rb

@@ -140,7 +140,7 @@ def involved_packages
 
   # returns the users that actually want email for this group's notifications
   def email_users
-    User.where(id: groups_users.where(email: true).select(:user_id))
+    User.where(id: groups_users.where(email: true).select(:user_id), state: 'confirmed')
   end
 
   def display_name