[frontend] Manually fix Lint/AmbiguousBlockAssociation offense

Mob-programming with @DavidKang
openSUSE · Dec 14, 2017 · f76c85d · f76c85d
1 parent dcd5d83
commit f76c85d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -52,12 +52,6 @@ Layout/MultilineMethodCallIndentation:
 Layout/MultilineOperationIndentation:
   Enabled: false
 
-# Offense count: 3
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'src/api/spec/controllers/webui/project_controller_spec.rb'
-    - 'src/api/spec/models/comment_spec.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith.

diff --git a/src/api/spec/controllers/webui/project_controller_spec.rb b/src/api/spec/controllers/webui/project_controller_spec.rb
@@ -1340,7 +1340,7 @@
           context 'elements position' do
             it { expect { move }.to change { path_elements[0].reload.position }.by(1) }
             it { expect { move }.to change { path_elements[1].reload.position }.by(-1) }
-            it { expect { move }.not_to change { path_elements[2].reload.position } }
+            it { expect { move }.not_to(change { path_elements[2].reload.position }) }
           end
         end
 
@@ -1359,7 +1359,7 @@
           end
 
           context 'elements position' do
-            it { expect { move }.not_to change { path_elements[0].reload.position } }
+            it { expect { move }.not_to(change { path_elements[0].reload.position }) }
             it { expect { move }.to change { path_elements[1].reload.position }.by(1) }
             it { expect { move }.to change { path_elements[2].reload.position }.by(-1) }
           end

diff --git a/src/api/spec/models/comment_spec.rb b/src/api/spec/models/comment_spec.rb
@@ -102,7 +102,7 @@
       end
 
       it "shouldn't be destroyed" do
-        expect { comment_package.blank_or_destroy }.to_not change { Comment.count }
+        expect { comment_package.blank_or_destroy }.to_not(change { Comment.count })
         expect(comment_package.body).to eq 'This comment has been deleted'
         expect(comment_package.user.login).to eq '_nobody_'
       end