Rename current_checks to checks

There is no more conflict with the relationship

src/api/app/models/staging/staging_project.rb

@@ -98,12 +98,12 @@ def unassign_managers_group(managers)
       relationships.find_by(group: managers, role: role).try(:destroy!)
     end
 
-    def current_checks
-      @current_checks ||= Status::Check.where(status_reports_id: relevant_status_reports_for_repositories | relevant_status_reports_for_architectures)
+    def checks
+      @checks ||= Status::Check.where(status_reports_id: relevant_status_reports_for_repositories | relevant_status_reports_for_architectures)
     end
 
-    def current_missing_checks
-      @current_missing_checks ||= (relevant_status_reports_for_repositories + relevant_status_reports_for_architectures).map(&:missing_checks).flatten
+    def missing_checks
+      @missing_checks ||= (relevant_status_reports_for_repositories + relevant_status_reports_for_architectures).map(&:missing_checks).flatten
     end
 
     def failed_status_checks
@@ -166,8 +166,8 @@ def relevant_status_reports_for_architectures
     end
 
     def check_state
-      return :testing if current_missing_checks.present? || current_checks.pending.exists?
-      return :failed if current_checks.failed.exists?
+      return :testing if missing_checks.present? || checks.pending.exists?
+      return :failed if checks.failed.exists?
       return :acceptable
     end
 

src/api/app/views/webui2/webui/staging/projects/show.html.haml

@@ -31,7 +31,6 @@
                        locals: { staging_project: @staging_project, items: @staging_project.broken_packages, type: 'broken_packages' }
             %tr
               = render partial: 'checks',
-                      locals: { checks: @staging_project.current_checks,
-                                missing_checks: @staging_project.current_missing_checks }
+                       locals: { checks: @staging_project.checks, missing_checks: @staging_project.missing_checks }
   .col-xl-2
     = render partial: 'webui/staging/shared/legend'

src/api/spec/models/staging/staging_project_spec.rb

@@ -133,7 +133,7 @@
       let!(:check) { create(:check, name: 'check_1', status_report: build_report, state: 'failure') }
 
       it { expect(staging_project.overall_state).to eq(:failed) }
-      it { expect(staging_project.current_checks).to contain_exactly(check) }
+      it { expect(staging_project.checks).to contain_exactly(check) }
     end
 
     context 'when there are succeeded checks' do
@@ -151,8 +151,8 @@
       end
 
       it { expect(staging_project.overall_state).to eq(:testing) }
-      it { expect(staging_project.current_missing_checks).to contain_exactly('check_1') }
-      it { expect(staging_project.current_checks).to be_empty }
+      it { expect(staging_project.missing_checks).to contain_exactly('check_1') }
+      it { expect(staging_project.checks).to be_empty }
     end
   end